Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9785] handle duplicate experiment keys with a warning #535

Merged
merged 4 commits into from
Nov 27, 2023
Merged

[FSSDK-9785] handle duplicate experiment keys with a warning #535

merged 4 commits into from
Nov 27, 2023
+47 −5

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Nov 21, 2023 •
edited
Loading

Summary

When duplicate experiment keys are found in a datafile, SDK returns a correct experimentMap in OptimizelyConfig:

  1. the experimentMap will contain the experiment later in the datafile experiments list.
  2. add a warning log about "Duplicate experiment keys found in datafile: {key-name}"

Test plan

  • add a test for OptimizelyConfig with duplicate experiment keys

Issues

@jaeopt jaeopt requested a review from a team as a code owner November 21, 2023 19:39
mikechu-optimizely
mikechu-optimizely approved these changes Nov 21, 2023
View reviewed changes
Copy link

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM no showstoppers but some thoughts 👇

core-api/src/main/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfigService.java Show resolved Hide resolved
core-api/src/main/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfigService.java Show resolved Hide resolved
core-api/src/test/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfigServiceTest.java Show resolved Hide resolved
core-api/src/test/java/com/optimizely/ab/optimizelyconfig/OptimizelyConfigServiceTest.java Show resolved Hide resolved
java-quickstart/src/main/java/com/optimizely/Example.java Outdated Show resolved Hide resolved
mikechu-optimizely
mikechu-optimizely approved these changes Nov 22, 2023
View reviewed changes
Copy link

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt merged commit e59c595 into master Nov 27, 2023
17 checks passed
@jaeopt jaeopt deleted the jae/FSSDK-9785 branch November 27, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaeopt @mikechu-optimizely