Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9493] fix: Added check in AsyncGetQualifiedSegments to check if userID is fsuserid or vuid #527

Merged
merged 2 commits into from
Jul 28, 2023
Merged

[FSSDK-9493] fix: Added check in AsyncGetQualifiedSegments to check if userID is fsuserid or vuid #527

merged 2 commits into from
Jul 28, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Jul 25, 2023 •
edited
Loading

Summary

  • This is to support other SDKs which are passing vuid as userid in async fetch qualified call

Test plan

  • Added unit test and all other tests should pass.

Issues

@mnoman09 mnoman09 requested a review from a team as a code owner July 25, 2023 23:58
jaeopt
jaeopt requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! A suggestion for testing.

core-api/src/test/java/com/optimizely/ab/OptimizelyUserContextTest.java Outdated
}, Collections.singletonList(ODPSegmentOption.RESET_CACHE));

countDownLatch2.await();
verify(mockODPSegmentManager).getQualifiedSegments(eq("vuid_f6db3d60ba3a493d8e41bc995bb"), any(ODPSegmentManager.ODPSegmentFetchCallback.class), eq(Collections.singletonList(ODPSegmentOption.RESET_CACHE)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we check "VUID" as user-key, not "FS_USER_ID"? That was the bug :)

@mnoman09 mnoman09 requested a review from jaeopt July 27, 2023 12:50
@mnoman09 mnoman09 removed their assignment Jul 27, 2023
@mnoman09 mnoman09 changed the title Added check in AsyncGetQualifiedSegments to check if userID is fsuserid or vuid [FSSDK-9493] fix: Added check in AsyncGetQualifiedSegments to check if userID is fsuserid or vuid Jul 27, 2023
jaeopt
jaeopt approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnoman09 mnoman09 merged commit f5528d5 into master Jul 28, 2023
14 of 16 checks passed
@mnoman09 mnoman09 deleted the mnoman/asyncFetchQFix branch July 28, 2023 16:10
@mnoman09 mnoman09 requested a review from jaeopt August 1, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt Awaiting requested review from jaeopt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @jaeopt @NomanShoaib