Move serialization to LogEvent.getBody(). #201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the serialization from POJO to JSON into
LogEvent#getBody()
. This allows the serialization of the event to be offloaded to with the event handler when the HTTP request is built. This should be 100% backwards compatible with any existingEventHandler
implementations. Initial benchmarks are much improved over the current master in tight loop simulations.Stats after 100,000 calls to
activate(...)
in my simulation:Note
2.0.0-beta2
was pre-batch endpoint, so isn't a valid comparison. Also performance runs can have some volatility, but the overall trends remain.I've also wrapped some calls to
logger.debug
inlogger.isDebugEnabled()
to prevent unused log statement from triggering the serialization synchronously.