Apply suggestions from code review

Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
optimizely · Apr 3, 2024 · 359552a · 359552a
1 parent 002bc92
commit 359552a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/core-httpclient-impl/src/main/java/com/optimizely/ab/NamedThreadFactory.java b/core-httpclient-impl/src/main/java/com/optimizely/ab/NamedThreadFactory.java
@@ -47,7 +47,7 @@ public NamedThreadFactory(String nameFormat, boolean daemon) {
     public NamedThreadFactory(String nameFormat, boolean daemon, ThreadFactory backingThreadFactory) {
         this.nameFormat = nameFormat;
         this.daemon = daemon;
-        this.backingThreadFactory = backingThreadFactory;
+        this.backingThreadFactory = backingThreadFactory != null ? backingThreadFactory :  Executors.defaultThreadFactory();
     }
 
     @Override

diff --git a/core-httpclient-impl/src/main/java/com/optimizely/ab/event/AsyncEventHandler.java b/core-httpclient-impl/src/main/java/com/optimizely/ab/event/AsyncEventHandler.java
@@ -136,12 +136,7 @@ public AsyncEventHandler(int queueCapacity,
             .withEvictIdleConnections(1L, TimeUnit.MINUTES)
             .build();
 
-        NamedThreadFactory namedThreadFactory;
-        if (threadFactory == null) {
-            namedThreadFactory = new NamedThreadFactory("optimizely-event-dispatcher-thread-%s", true);
-        } else {
-            namedThreadFactory = new NamedThreadFactory("optimizely-event-dispatcher-thread-%s", true, threadFactory);
-        }
+        NamedThreadFactory namedThreadFactory = new NamedThreadFactory("optimizely-event-dispatcher-thread-%s", true, threadFactory);
 
         this.workerExecutor = new ThreadPoolExecutor(numWorkers, numWorkers,
                                                      0L, TimeUnit.MILLISECONDS,