Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-10265] fix: UPS
Lookup
&Save
during batched Decide #374[FSSDK-10265] fix: UPS
Lookup
&Save
during batched Decide #374Changes from 14 commits
963fc07
d0f59b6
14dface
66708d8
aa0d018
dd072b9
f9f3f3f
b43e10f
0dd1b74
2b17438
c9047a0
dfe1367
57c1ccd
9ca271c
c97f36e
5b7e5ae
c6889e8
2f46b18
54a2dc2
9f2f471
73658f6
80e73d4
236728b
d6258f1
9c6e9bb
49f9584
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests look good. Wondering if we have tests covering the contents of the final UPS save call, combining all decisions in the session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also have the similar coverage (lookup once - save once, the ups save contents) with legacy APIs (activate, getVariation) for regression?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added coverage of the final UPS
Save
as requested.I'm researching the
Activate
andGetVariation
tests where UPS is used.