Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10523] forward exceptions for un-expected response from ODP #488

Merged
merged 2 commits into from
Aug 20, 2024
Merged

[FSSDK-10523] forward exceptions for un-expected response from ODP #488

merged 2 commits into from
Aug 20, 2024

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Aug 12, 2024 •
edited
Loading

Summary

  • As per demand of HSBC, forwarding exception for unexpected sever response from ODP

Issues

jaeopt
jaeopt approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you edit the PR description and make sure it passes the unit tests?

@muzahidul-opti muzahidul-opti changed the title Null segment exception added [FSSDK-10563] forward exceptions for un-expected response from ODP Aug 20, 2024
@muzahidul-opti muzahidul-opti changed the title [FSSDK-10563] forward exceptions for un-expected response from ODP [FSSDK-10523] forward exceptions for un-expected response from ODP Aug 20, 2024
@muzahidul-opti muzahidul-opti marked this pull request as ready for review August 20, 2024 05:59
@muzahidul-opti muzahidul-opti requested a review from a team as a code owner August 20, 2024 05:59
@muzahidul-opti muzahidul-opti merged commit 049ec0a into master Aug 20, 2024
6 of 15 checks passed
@muzahidul-opti muzahidul-opti deleted the muzahid/fix-fsgmnt-null-exception branch August 20, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @jaeopt