Skip to content

[FSSDK-9406] fix: Added catch block to capture resource not found exception #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

[FSSDK-9406] fix: Added catch block to capture resource not found exception #460

merged 1 commit into from
Jul 10, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Jul 7, 2023

Summary

Test plan

All tests should pass

Issues

@mnoman09 mnoman09 requested a review from a team as a code owner July 7, 2023 15:58
@mnoman09 mnoman09 changed the title fix: Added catch block to capture resource not found exception [FSSDK-9406] fix: Added catch block to capture resource not found exception Jul 7, 2023
@mnoman09 mnoman09 removed their assignment Jul 7, 2023
@mnoman09 mnoman09 requested a review from jaeopt July 7, 2023 16:00
jaeopt
jaeopt approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnoman09 mnoman09 merged commit 9787408 into master Jul 10, 2023
@mnoman09 mnoman09 deleted the mnoman/FSSDK-9406-bug branch July 10, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
🤖 4 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnoman09 @jaeopt @optimizely-codereview-bot @NomanShoaib