Fix: Setdatafile of defaultDatafileHandler is returning null datafile #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnoman09
changed the title
thomaszurkan-optimizely
approved these changes
Jul 11, 2019
thomaszurkan-optimizely
added a commit
that referenced
this pull request
Jul 11, 2019
…o add listener. (#276) * first attempt at using the project config manager with android * add datafile change notification * fix unit tests * update to latest build versions * trying to fix travis * try to get travis working * remove audio from emulator start * incorrect check for currentConfig * fix travis yaml * use 3.2.0 java-sdk * fall back to tools 28.0.3 * cleanup travis yaml * trying to fix travis build * respond to comments, slight refactor. * use datafileloaded as datafile change. deprecate datafile handler interface. * one more slight refactor. remove datafile config from constructor of default datafile handler. allow old handlers to work the same as before using datafile only. fix tests * slight refactor for setConfig * cleanup test-app a little * cleanup from PR comments * removed not from null datafile or empty datafile check (#279) * add a few more null checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "why", or other context.
Test plan
Issues
getClass()which uses reflection with explicit class #123"