Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add andThen on all optics #967

Merged
merged 6 commits into from
Nov 26, 2020
Merged

add andThen on all optics #967

merged 6 commits into from
Nov 26, 2020

Conversation

julien-truffaut
Copy link
Member

see #964

I believe we can deprecate all composeX methods once we have a short cut for at, index and maybe a few other common optics.

@julien-truffaut
Copy link
Member Author

@cquiroz @yilinwei are you ok with this change?

cquiroz
cquiroz approved these changes Nov 26, 2020
View reviewed changes
Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems fine to me, we still have the old names there so it won't break existing code I think

@yilinwei
Copy link
Collaborator

👍

@julien-truffaut
Copy link
Member Author

it seems fine to me, we still have the old names there so it won't break existing code I think

I agree. I would like to eventually deprecate the old names.

@julien-truffaut julien-truffaut merged commit 8421493 into master Nov 26, 2020
@xuwei-k xuwei-k deleted the andThen branch September 25, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julien-truffaut @yilinwei @cquiroz