Improve error messages for the Focus macro.
#1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yilinwei
requested review from
julien-truffaut,
cquiroz and
xuwei-k
as code owners
- Correctly widen inferred singleton types for the error message. - Propagate the position information for user errors.
yilinwei
commented
Dec 20, 2023
| def getFieldSymbol(fromTypeSymbol: Symbol): Symbol = { | ||
| // We need to do this to support tuples, because even though they conform as case classes in other respects, | ||
| // for some reason their field names (_1, _2, etc) have a space at the end, ie `_1 `. | ||
| val f: String => String = |
There was a problem hiding this comment.
This fixes a silent error if we have something like
case class Foo(x: Int, `x `: Int)since identifiers with leading/trailing spaces are not equivalent.
yilinwei
commented
Dec 20, 2023
| def errorMessage(error: FocusError): String = error match { | ||
| case FocusError.NotACaseClass(fromClass, fieldName) => | ||
| s"Cannot generate Lens for field '$fieldName', because '$fromClass' is not a case class" | ||
| def errorReport(error: FocusError): (String, Option[Position]) = error match { |
There was a problem hiding this comment.
The dotty macro API has better support for errors now.
As a tangent, I need to see whether we can use the -explain flag which would be helpful to expand internal errors.
julien-truffaut
approved these changes
Dec 21, 2023
|
Thanks @yilinwei, it looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few random changes which are (mostly) forced by compiler changes.
I think I'll change the hierarchy of the
FocusErrora little, because some of the errors are internal i.e.5xxand some are4xx; mixing them is quite confusing.