Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

as for AppliedOptics #1123

Merged
merged 4 commits into from
Mar 14, 2021
Merged

as for AppliedOptics #1123

merged 4 commits into from
Mar 14, 2021

Conversation

julien-truffaut
Copy link
Member

  1. Fix a bug in AppliedIso constructor thanks to @kenbot
  2. defined an alias for AppliedGetter and AppliedFold in the top level monocle package

kenbot
kenbot approved these changes Mar 14, 2021
View reviewed changes
Copy link
Collaborator

@kenbot kenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julien-truffaut julien-truffaut merged commit b3b2b93 into master Mar 14, 2021
@xuwei-k xuwei-k deleted the applied-as branch September 25, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenbot kenbot kenbot approved these changes

@cquiroz cquiroz Awaiting requested review from cquiroz cquiroz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-truffaut @kenbot