[Focus] Each feature #1072
Merged
[Focus] Each feature #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
… get stuck on singleton paths
|
It looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
eachto the Focus macro, resolving #1029.Some more bits and pieces:
composeOpticsmethod to be two lines, owing to a horrendous Dotty compiler space leak the old version was causing now that Traversals are in the mix.ParseResulttype alias. Give it to me straight_root_.monocle.this.that...., which is a habit I had picked up writing macros in stringier environments. They are real typechecked Scala symbols, there's no chance of ambiguity or accidental capture of some other symbol by the same name.