Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenLens for Scala 3, redirect to Focus #1037

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

julien-truffaut
Copy link
Member

@julien-truffaut julien-truffaut commented Feb 8, 2021

/cc @asjad02

Macros

Generic

  • move generic tests to generic module

Tests

  • enable Scala 3
  • remove all usage of GenX in test module
  • remove shapeless
  • disable StringsSpec, there was an issue with ScalaCheck and refined (I will investigate in a separate ticket)

Todo later

The alternative for macros is to wait for Scala 2.13.5 which should allow to cross compile macro to Dotty. However, I am bit worried how our build will handle it (2.13, 3.0 and 2.13 compiling to 3.0).

Copy link
Collaborator

@kenbot kenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

I think at some point we will have to revisit the GenXXX and Focus tests and unify them into something that makes sense. But it doesn't have to happen in this PR, I think, it can come later.

@julien-truffaut julien-truffaut merged commit 12c89e1 into master Feb 9, 2021
@julien-truffaut julien-truffaut deleted the genlens-scala3 branch February 9, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants