integrate master password with aws secret manager #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiyerra
requested changes
Sep 21, 2023
sql.tf
Outdated
| @@ -5,6 +5,10 @@ resource "aws_db_subnet_group" "default" { | |||
| tags = local.tags | |||
| } | |||
|
|
|||
| resource "aws_kms_key" "example" { | |||
sql.tf
Outdated
| @@ -44,7 +47,7 @@ resource "aws_rds_cluster_instance" "cluster_instances" { | |||
|
|
|||
| monitoring_role_arn = var.monitoring_role_arn | |||
| monitoring_interval = 5 | |||
| performance_insights_enabled = var.sql_performance_insights_enabled | |||
| performance_insights_enabled = var.performance_insights_enabled | |||
There was a problem hiding this comment.
Need to update this to sql_performance_insights_enabled
sql.tf
Outdated
| @@ -78,7 +81,5 @@ resource "aws_db_instance" "default" { | |||
| backup_retention_period = 35 | |||
| deletion_protection = true // Don't Delete Ever! Except manually. | |||
|
|
|||
| iam_database_authentication_enabled = var.sql_iam_auth_enabled | |||
abhiyerra
requested changes
Sep 21, 2023
sql.tf
Outdated
| @@ -5,6 +5,10 @@ resource "aws_db_subnet_group" "default" { | |||
| tags = local.tags | |||
| } | |||
|
|
|||
| resource "aws_kms_key" "example" { | |||
| description = "Example KMS Key" | |||
There was a problem hiding this comment.
descriptions = "${local.environment} RDS KMS Key"
Set prevent_destroy = true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #256
Code Checklist
Ensure the following tasks are completed.
poetry add?make makemigrations && make migratemake upwork?helm template show ./charts/opszerowork?ReviewcolumnReviewer Checklist
Business Checklist