Fix git auth prompting and allow config of '.git' auto suffix #5078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5078 will not alter performanceComparing Summary
|
sdktr
reviewed
Nov 28, 2024
| ): | ||
| data["location"]["value"] = f'{data["location"]["value"]}.git' | ||
| if config.SETTINGS.git.append_git_suffix: | ||
| http_without_dotgit = r"^(https?://)(?!.*\.git$).*" |
There was a problem hiding this comment.
is git supported over https only transport?
There was a problem hiding this comment.
This is just a regex that would look at the repository URL and optionally add a suffix if the URL is http or https.
ogenstad
force-pushed
the
pog-no-auth-prompt-configure-auto-suffix-IFC-967
branch
from
fc3911c to
2757c50
Compare
dgarros
approved these changes
Nov 29, 2024
ogenstad
deleted the
pog-no-auth-prompt-configure-auto-suffix-IFC-967
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we set the environment variable to Git so that we never prompt for credentials (in the console of the docker container), this change reflects the what we had with the old git agent.
It also adds a configuration option that lets users disable the automatic suffix of ".git" that Infrahub adds to HTTP repositories if this string wasn't appended to the URL.
Fixes #5077