Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search anywhere to use cmdk and fix focus issues - IFC-837 #5039

Merged
merged 13 commits into from
Nov 27, 2024

Conversation

pa-lem
Copy link
Contributor

@pa-lem pa-lem commented Nov 25, 2024

Issue: #4715

  • Migrates from headless combobox to cmdk
  • Fixes focus issues when clicking outside + no result found

@pa-lem pa-lem added the group/frontend Issue related to the frontend (React) label Nov 25, 2024
@pa-lem pa-lem requested a review from bilalabbad November 25, 2024 15:31
@pa-lem pa-lem added the type/bug Something isn't working as expected label Nov 25, 2024
@pa-lem pa-lem marked this pull request as ready for review November 25, 2024 15:46
@bilalabbad bilalabbad added the cd/preview Deploy preview branch label Nov 26, 2024
changelog/4715.fixed.md Outdated Show resolved Hide resolved
@bilalabbad
Copy link
Contributor

We could not navigate using keyboard anymore?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@pa-lem pa-lem merged commit 2800fb2 into stable Nov 27, 2024
29 checks passed
@pa-lem pa-lem deleted the ple-search-cmdk branch November 27, 2024 09:02
@LucasG0 LucasG0 mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cd/preview Deploy preview branch group/frontend Issue related to the frontend (React) type/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants