Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generators and artifacts to run on node without name attribute #4187

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Allow generators and artifacts to run on node without name attribute #4187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2757d2e
Use display label instead of name
BaptisteGi Aug 27, 2024
6054f03
Add changelog shard
BaptisteGi Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/infrahub/message_bus/operations/requests/artifact_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ async def check(message: messages.RequestArtifactDefinitionCheck, service: Infra
query=message.artifact_definition.query_name,
variables=member.extract(params=artifact_definition.parameters.value),
target_id=member.id,
target_name=member.name.value,
target_name=member.display_label,
timeout=message.artifact_definition.timeout,
validator_id=validator.id,
meta=Meta(validator_execution_id=validator_execution_id, check_execution_id=check_execution_id),
Expand Down Expand Up @@ -203,7 +203,7 @@ async def generate(message: messages.RequestArtifactDefinitionGenerate, service:
query=query.name.value,
variables=member.extract(params=artifact_definition.parameters.value),
target_id=member.id,
target_name=member.name.value,
target_name=member.display_label,
timeout=transform.timeout.value,
)
)
Expand Down
4 changes: 2 additions & 2 deletions backend/infrahub/message_bus/operations/requests/generator_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ async def check(message: messages.RequestGeneratorDefinitionCheck, service: Infr
query=message.generator_definition.query_name,
variables=member.extract(params=message.generator_definition.parameters),
target_id=member.id,
target_name=member.name.value,
target_name=member.display_label,
validator_id=validator.id,
meta=Meta(validator_execution_id=validator_execution_id, check_execution_id=check_execution_id),
)
Expand Down Expand Up @@ -177,7 +177,7 @@ async def run(message: messages.RequestGeneratorDefinitionRun, service: Infrahub
query=message.generator_definition.query_name,
variables=member.extract(params=message.generator_definition.parameters),
target_id=member.id,
target_name=member.name.value,
target_name=member.display_label,
)
)

Expand Down
1 change: 1 addition & 0 deletions changelog/4062.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Allow users to run artifacts and generators on nodes without name attribute
Loading