-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update rowan
and rnix
for pipe-operator support
#93
Open
RobWalt
wants to merge
30
commits into
oppiliappan:master
Choose a base branch
from
RobWalt:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new behavior is reasonable. In case of a double empty concatenation, which is already pretty uncommon, the lint would suggest to remove the second empty concat first instead of the first empty concat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to solve #88.
rnix-parser
until a new release is made (see Bumped library version nix-community/rnix-parser#168 (comment) for details).Remark
This PR kind of got out of hand. If you want I can split it up into several smaller PRs. Some extra work done:
lazy_static
withstd::sync::LazyLock
if_chain
in favor of regular good old?
LintMap
a bit. It was emitting a clippy warning because it used&'static Box<dyn Something>
. Now it usesArc<Box<dyn Something>>
instead. This change is related to thelazy_static
onecargo deny
freaked out because some deps were in desparate need of an update. As a side effect, the crate has less dependencies and the tests are slightly faster when measured against current master withhyperfine
nowlints
macro. Together with theif_chain
change this means that rustfmt will work better on the lints now