Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update rowan and rnix for pipe-operator support #93

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

RobWalt
Copy link

@RobWalt RobWalt commented Jan 9, 2025

This aims to solve #88.

Remark

This PR kind of got out of hand. If you want I can split it up into several smaller PRs. Some extra work done:

  • replace lazy_static with std::sync::LazyLock
  • remove if_chain in favor of regular good old ?
  • refactor LintMap a bit. It was emitting a clippy warning because it used &'static Box<dyn Something>. Now it uses Arc<Box<dyn Something>> instead. This change is related to the lazy_static one
  • update a whole bunch of other dependencies. cargo deny freaked out because some deps were in desparate need of an update. As a side effect, the crate has less dependencies and the tests are slightly faster when measured against current master with hyperfine now
  • Remove the lints macro. Together with the if_chain change this means that rustfmt will work better on the lints now
  • Some other minor refactors of old rust patterns, updating them with the new shiny stuff that was released in the meantime

@RobWalt RobWalt marked this pull request as ready for review January 10, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant