Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2819: Add Label for AudioLangaugeActivity #2924

Closed
wants to merge 1 commit into from
Closed

Fix #2819: Add Label for AudioLangaugeActivity #2924

wants to merge 1 commit into from

Conversation

arjunrkaushik
Copy link

@arjunrkaushik arjunrkaushik commented Mar 16, 2021

##Explanation

Fixes #2819: Adds Label for AudioLangaugeActivity

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 self-assigned this Mar 16, 2021
@arjunrkaushik
Copy link
Author

@rt4914 Could you please help me figure out why the 3 checks are failing...

@rt4914
Copy link
Contributor

rt4914 commented Mar 17, 2021

@arjunrkaushik Can you pick some other issue. Actually this issue is getting solved in #2784 so therefore I will be closing this PR and the original issue too.

As far as your tests are concerned they are failing because you are passing null as summaryValue.

@rt4914 rt4914 closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for AudioLanguageActivity
2 participants