Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2819: Adds label to AudioLanguageActivity #2902

Closed
wants to merge 1 commit into from
Closed

Fix #2819: Adds label to AudioLanguageActivity #2902

wants to merge 1 commit into from

Conversation

arjunrkaushik
Copy link

@arjunrkaushik arjunrkaushik commented Mar 14, 2021

Fixes #2819 : Adds label to AudioLanguageActivity

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Arjun,
We also require a test case to verify this, so can you please add one?

Comment on lines +60 to +61
android:theme="@style/OppiaThemeWithoutActionBar"
android:label="@string/audio_language_activity"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires reformatting, press Ctrl + Shift + L to reformat.

@prayutsu
Copy link
Contributor

@arjunrkaushik A few quick tips for making a good PR -

  1. The branch name should be descriptive and different words should be separated by hyphens (No other characters should be used except lowercase English alphabet and '-').
  2. The commit messages should never include keywords like Fixes #bugNum because it leads to unnecessary mentions of the commit in the issue description.
  3. When PR is ready for review, add a "PTAL" comment by mentioning any reviewers like - @{reviewerName} PTAL. This comment ensures that PR is ready to review from your side (if the author does not leave a PTAL comment then the reviewer may think that the author wants to add more commits in the PR)

I suggest going through the Making a Code Change Instructions once.

@rt4914
Copy link
Contributor

rt4914 commented Mar 15, 2021

Thanks @prayutsu .Feel free to assign me for reviews once you approve it.

@arjunrkaushik arjunrkaushik deleted the arjunrk branch March 16, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for AudioLanguageActivity
3 participants