Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part 5661:Add Missing style Attributes to TextViews #5710

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Harsh2118-hub
Copy link

@Harsh2118-hub Harsh2118-hub commented Feb 21, 2025

PR Summary
This PR introduces several style improvements for TextView components across various layout files in the project. It centralizes text styling into reusable styles defined in styles.xml, promoting consistency and maintainability.

Changes
Applied styles to TextViews in the following layout files:
walkthrough_final_fragment.xml
drawer_fragment.xml
feedback_item.xml
item_selection_interaction_items.xml
lessons_completed_chapter_view.xml
lessons_in_progress_chapter_view.xml
lessons_locked_chapter_view.xml
lessons_not_started_chapter_view.xml
onboarding_language_dropdown_item.xml
profile_list_sync_status_item.xml
test_text_view_bindable_adapter_activity.xml

Updated styles.xml with new styles for TextViews, including:
WalkthroughFinalNoTextViewStyle
WalkthroughFinalYesTextViewStyle
DeveloperOptionsTextViewStyle
OnboardingLanguageTextViewStyle
WalkthroughFinalTitleTextViewStyle
ChapterIndexTextViewStyle
TestTextViewStyle
FeedbackTextViewStyle
ItemSelectionContentsTextViewStyle
LearnerAnalyticsSyncStatusTextViewStyle

Updated TextViewStyleCheck.kt to ensure compliance with the new styles and also removed the duplicate attributes ids mentioned before . The new list =>
"@+id/text_view_for_int_no_data_binding",
"@+id/walkthrough_topic_name_text_view",
"@+id/walkthrough_lesson_count_text_view",
"@+id/hint_bar_title",
"@+id/coming_soon_text_view",
"@+id/topic_name_text_view",
"@+id/lesson_count_text_view",
"@+id/multiple_choice_content_text_view",
"@+id/language_text_view",
"@+id/welcome_text_view",
"@+id/app_version_text_view",
"@+id/app_last_update_date_text_view",
"@+id/test_margin_text_view",
"@+id/content_text_view",
"@+id/action_options",
"@+id/action_help",
"@+id/action_close",
"@+id/continue_studying_text_view",
"@+id/language_unavailable_notice",
"@+id/story_progress_chapter_completed_text",
"@+id/profile_id_view_profile_name",
"@+id/profile_id_view_learner_id",
"@+id/learner_events_waiting_upload_label",
"@+id/learner_events_waiting_upload_count",
"@+id/learner_events_uploaded_label",
"@+id/learner_events_uploaded_count",
"@+id/uncategorized_events_waiting_upload_label",
"@+id/uncategorized_events_waiting_upload_count",
"@+id/uncategorized_events_uploaded_label",
"@+id/uncategorized_events_uploaded_count",
"@+id/text_view_for_live_data_no_data_binding",
"@+id/selection_interaction_textview",
"@+id/onboarding_steps_count",
"@+id/profile_picture_edit_dialog_view_picture",
"@+id/profile_picture_edit_dialog_change_picture",
"@+id/chapter_title",
"@+id/walkthrough_welcome_title_text_view",
"@+id/story_name_text_view",
"@+id/copyright_license_text_view",
"@+id/ga_update_notice_dialog_message",
"@+id/create_profile_picture_prompt",
"@+id/profile_reset_pin_main",
"@+id/submitted_answer_text_view",
"@+id/end_session_header_text_view",
"@+id/end_session_body_text_view",
"@+id/question_progress_text",
"@+id/congratulations_text_view",
"@+id/beta_notice_dialog_message",
"@+id/onboarding_language_explanation",
"@+id/create_profile_title",
"@+id/profile_name_text_view",
"@+id/resume_lesson_chapter_title_text_view",
"@+id/story_count_text_view",
"@+id/download_size_text_view",
"@+id/options_activity_selected_options_title",
"@+id/profile_select_text",
"@+id/extra_controls_title",
"@+id/view_all_text_view"

Fixes #5661

Essential Checklist

  • [ x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • [x ] Any changes to scripts/assets files have their rationale included in the PR explanation.
  • [ x] The PR follows the style guide.
  • [x ] The PR does not contain any unnecessary code changes from Android Studio (reference).
  • [ x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • [ x] The PR is assigned to the appropriate reviewers (reference).

Updated TextView elements to use centrally managed styles, ensuring consistency across the app. Removed their IDs from the exception list in .

This change improves UI consistency and maintains adherence to Oppia Android's styling guidelines.
@Harsh2118-hub Harsh2118-hub requested review from a team as code owners February 21, 2025 14:15
@Harsh2118-hub
Copy link
Author

Apologies for the inconvenience, but the previous PR was deleted due to a mistake on my end. I’ve created a new PR with the same content, and everything should be in order now. Thank you for your understanding and support! @adhiamboperes @manas-yu

@Harsh2118-hub Harsh2118-hub changed the title Fix5661:Add Missing style Attributes to TextViews Fix part 5661:Add Missing style Attributes to TextViews Feb 21, 2025
@Harsh2118-hub
Copy link
Author

please @manas-yu @adhiamboperes , i request a re-review

@Harsh2118-hub
Copy link
Author

WhatsApp Image 2025-02-21 at 9 55 08 PM
WhatsApp Image 2025-02-21 at 9 55 08 PM (1)
WhatsApp Image 2025-02-21 at 9 55 09 PM
WhatsApp Image 2025-02-21 at 9 55 09 PM (1)
WhatsApp Image 2025-02-21 at 9 55 10 PM
WhatsApp Image 2025-02-21 at 9 55 11 PM
WhatsApp Image 2025-02-21 at 9 55 11 PM (1)
WhatsApp Image 2025-02-21 at 9 55 12 PM

Copy link

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 3516 bytes (Added)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 1556 bytes (Added)

Method count: 260308 (old), 260308 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6832 (old), 6842 (new), 10 (Added)

  • Anim: 43 (old), 43 (new), 0 (No change)
  • Animator: 26 (old), 26 (new), 0 (No change)
  • Array: 15 (old), 15 (new), 0 (No change)
  • Attr: 922 (old), 922 (new), 0 (No change)
  • Bool: 9 (old), 9 (new), 0 (No change)
  • Color: 967 (old), 967 (new), 0 (No change)
  • Dimen: 1048 (old), 1048 (new), 0 (No change)
  • Drawable: 380 (old), 380 (new), 0 (No change)
  • Id: 1285 (old), 1285 (new), 0 (No change)
  • Integer: 37 (old), 37 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 380 (old), 380 (new), 0 (No change)
  • Menu: 3 (old), 3 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • Raw: 2 (old), 2 (new), 0 (No change)
  • String: 855 (old), 855 (new), 0 (No change)
  • Style: 832 (old), 842 (new), 10 (Added):
    • style/ChapterIndexTextViewStyle (added)
    • style/DeveloperOptionsTextViewStyle (added)
    • style/FeedbackTextViewStyle (added)
    • style/ItemSelectionContentsTextViewStyle (added)
    • style/LearnerAnalyticsSyncStatusTextViewStyle (added)
    • And 5 others
  • Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 3480 bytes (Added)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 2234 bytes (Added)
Resources: 6782 (old), 6792 (new), 10 (Added)

  • Style: 832 (old), 842 (new), 10 (Added)

Configuration hdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 2764 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 1667 bytes (Added)

Method count: 115790 (old), 115790 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5800 (old), 5810 (new), 10 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 820 (new), 0 (No change)
  • Dimen: 780 (old), 780 (new), 0 (No change)
  • Drawable: 342 (old), 342 (new), 0 (No change)
  • Id: 1231 (old), 1231 (new), 0 (No change)
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 343 (new), 0 (No change)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 788 (old), 788 (new), 0 (No change)
  • Style: 473 (old), 483 (new), 10 (Added):
    • style/ChapterIndexTextViewStyle (added)
    • style/DeveloperOptionsTextViewStyle (added)
    • style/FeedbackTextViewStyle (added)
    • style/ItemSelectionContentsTextViewStyle (added)
    • style/LearnerAnalyticsSyncStatusTextViewStyle (added)
    • And 5 others
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 11 MiB (old), 11 MiB (new), 2720 bytes (Added)
APK download size (estimated): 10 MiB (old), 10 MiB (new), 364 bytes (Added)
Resources: 5757 (old), 5767 (new), 10 (Added)

  • Style: 473 (old), 483 (new), 10 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 2916 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 1191 bytes (Added)

Method count: 115796 (old), 115796 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5800 (old), 5810 (new), 10 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 820 (new), 0 (No change)
  • Dimen: 780 (old), 780 (new), 0 (No change)
  • Drawable: 342 (old), 342 (new), 0 (No change)
  • Id: 1231 (old), 1231 (new), 0 (No change)
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 343 (new), 0 (No change)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 788 (old), 788 (new), 0 (No change)
  • Style: 473 (old), 483 (new), 10 (Added):
    • style/ChapterIndexTextViewStyle (added)
    • style/DeveloperOptionsTextViewStyle (added)
    • style/FeedbackTextViewStyle (added)
    • style/ItemSelectionContentsTextViewStyle (added)
    • style/LearnerAnalyticsSyncStatusTextViewStyle (added)
    • And 5 others
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 2872 bytes (Added)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 1658 bytes (Added)
Resources: 5757 (old), 5767 (new), 10 (Added)

  • Style: 473 (old), 483 (new), 10 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 2932 bytes (Added)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 2355 bytes (Added)

Method count: 115796 (old), 115796 (new), 0 (No change)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5800 (old), 5810 (new), 10 (Added)

  • Anim: 33 (old), 33 (new), 0 (No change)
  • Animator: 24 (old), 24 (new), 0 (No change)
  • Array: 14 (old), 14 (new), 0 (No change)
  • Attr: 888 (old), 888 (new), 0 (No change)
  • Bool: 8 (old), 8 (new), 0 (No change)
  • Color: 820 (old), 820 (new), 0 (No change)
  • Dimen: 780 (old), 780 (new), 0 (No change)
  • Drawable: 342 (old), 342 (new), 0 (No change)
  • Id: 1231 (old), 1231 (new), 0 (No change)
  • Integer: 32 (old), 32 (new), 0 (No change)
  • Interpolator: 11 (old), 11 (new), 0 (No change)
  • Layout: 343 (old), 343 (new), 0 (No change)
  • Menu: 1 (old), 1 (new), 0 (No change)
  • Mipmap: 1 (old), 1 (new), 0 (No change)
  • Plurals: 10 (old), 10 (new), 0 (No change)
  • String: 788 (old), 788 (new), 0 (No change)
  • Style: 473 (old), 483 (new), 10 (Added):
    • style/ChapterIndexTextViewStyle (added)
    • style/DeveloperOptionsTextViewStyle (added)
    • style/FeedbackTextViewStyle (added)
    • style/ItemSelectionContentsTextViewStyle (added)
    • style/LearnerAnalyticsSyncStatusTextViewStyle (added)
    • And 5 others
  • Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

  • hdpi (same)
  • ldpi (same)
  • mdpi (same)
  • tvdpi (same)
  • xhdpi (same)
  • xxhdpi (same)
  • xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 2884 bytes (Added)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 3371 bytes (Added)
Resources: 5757 (old), 5767 (new), 10 (Added)

  • Style: 473 (old), 483 (new), 10 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

@adhiamboperes adhiamboperes self-assigned this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Missing style Attributes to TextViews
2 participants