-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Add Missing style Attributes to TextViews #5661
Comments
@adhiamboperes please assign me this issue. |
@Harsh2118-hub, I am assigning this issue to you. Please note that, the linked list of ids is for 100 textviews, so the expectation is to create a PR with not more than 10 ids at a time. This is because you need to upload before and after screenshots for each screen that you have added a style for, so that we can verify that it looks the same as it is currently. |
I am encountering an issue where I cannot find the file Thank you! |
Hi @Harsh2118-hub, the changes in #5599 are yet to be merged but should be merged soon. In the meantime, you can reference the TextView IDs here. |
@Harsh2118-hub, the TextViewStyleCheck script is now available. Please update your branch and pull the latest changes to access it. |
Updated TextView elements to use centrally managed styles, ensuring consistency across the app. Removed their IDs from the exception list in . This change improves UI consistency and maintains adherence to Oppia Android's styling guidelines.
Is your feature request related to a problem? Please describe.
The
TextViewStyleCheck
script was introduced in #5599 to ensure all TextView elements in layout XML files use centrally managed styles to support consistent design and proper RTL/LTR settings. However, a list of hardcoded exceptions (attributeIds) has been added to bypass the style check for specific TextView elements that currently lack a style attribute.This issue aims to address these exceptions by updating the respective
TextView
elements to include appropriate centrally managed style attributes.Describe the solution you'd like
TextView
element to use the identified or newly created style, and then remove its ID from the attributeIds list in theTextViewStyleCheck
script.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: