net/frr - style cleanup and unify forms #4450
Conversation
|
@mimugmail @fabianfrz do you mind if I change the maintainer of this plugin to myself? |
Apply frontend / api changes to align more with current core patterns.
AdSchellevis
force-pushed
the
frr_cleanup
branch
from
4a0bfa0 to
1a47be2
Compare
|
@mimugmail thanks, looking at the last couple of years, you have been most active on the subject, so I'll change the maintainer in this PR for clarity. We're slowly bringing the plugin and documentation "up to spec" from our end, @Monviech added docs earlier in opnsense/docs#629, restructuring the code has been on my list for quite some time. |
|
Be aware that FRR9 and FRR10 brings lots of breaking changes, e.g. switching from separated config files to one huge, I can create a tracking issue with all relavant breakings |
|
@mimugmail yes please, if you have the time and spirit, we should probably plan an upgrade together (and determine what the next target should be). It's probably a good opportunity to refactor the configuration files as well anyway, I left those out for now to lower the risk. |
|
@mimugmail @AdSchellevis I was always the maintainer of a lot of stuff because I wrote the initial plugins. I am more than happy if you take over the maitainership as I am not really working on it anymore. BTW: A big thanks should go to mimugmail as he extended them a lot. |
|
@fabianfrz very logical, thanks for starting this venture, it was (and is) an important addition. @mimugmail has spend quite some time on the subject indeed and I hope he will keep doing that to help improve this part of our system. |
Apply frontend / api changes to align more with current core patterns.
This has been on my list for quite some time, but finally found some time to cleanup the frontend code.