Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface assignments to API #8436

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

black3x3
Copy link

Although the issue is closed, I have worked on it as I also need this functionality. Additionally, I have opened two pull requests in the following repositories:
- https://github.com/browningluke/terraform-provider-opnsense
- https://github.com/browningluke/opnsense-go repositories

I would appreciate a review and would be happy to improve the quality of the changes.

@AdSchellevis
Copy link
Member

Unfortunately this is unlikely to mature as it will need a lot of time from our end to bring this to the finish line. In order to include an api on a component on our end, the ui parts should also be finished. I'll keep the ticket open for when we start planning the work on our end.

@AdSchellevis AdSchellevis self-assigned this Mar 14, 2025
@vpereira
Copy link

Unfortunately this is unlikely to mature as it will need a lot of time from our end to bring this to the finish line. In order to include an api on a component on our end, the ui parts should also be finished. I'll keep the ticket open for when we start planning the work on our end.

Hello, thank you for your answer!

In order to include an api on a component on our end, the ui parts should also be finished

Could you please take a look in this PR? The "Assignment" UI is already in place, so i fail to see which UI has to be written here. I can however extend the UI too, if needed

I'll keep the ticket open for when we start planning the work on our end.

It is a working PR, which together with the other two related PRs (see the description) that allow users to access it programmatically via terraform

@fichtner moooin if we cannot get this code into the mainline, would be a possible/good idea to write it as plugin? I am wondering if it doesn't get merged, how to keep my opnsense up-to-date and still apply my custom code ❓

@AdSchellevis
Copy link
Member

.. Could you please take a look in this PR? The "Assignment" UI is already in place,...

It's not as there's no user interface using the exact same endpoints (which is a requirement).

moooin if we cannot get this code into the mainline, would be a possible/good idea to write it as plugin?

best keep the plugin local at your end, no need to push it to our repository.

Eventually we will refactor the assignments as well, it's just not yet on the list.

@fichtner
Copy link
Member

@vpereira hi there long time no see :) it's on my wish list and why we have cleaned up the interface.php page already WRT PPP devices, but it's such a huge chunk of work that this won't be happening this year for sure. Also we have had bad experiences with interim solutions such as this in the past. What's your current use case?

@vpereira
Copy link

@vpereira hi there long time no see :)

Hey @fichtner yeah, too long actually :)

What's your current use case?

We are in the pursuit of automating stuff with Terraform, and with this PR in combination with browningluke/terraform-provider-opnsense#60 is a huge leap forward. Our goal is to handle OPNsense change requests in a GitOps style, so we can deploy them via CI/CD and all that jazz. It's what the cool kids do these days 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants