Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oracle_sql module splits even on quoted sql delimeter #68

Closed
bartowl opened this issue Sep 23, 2021 · 0 comments · Fixed by #69
Closed

oracle_sql module splits even on quoted sql delimeter #68

bartowl opened this issue Sep 23, 2021 · 0 comments · Fixed by #69

Comments

@bartowl
Copy link

bartowl commented Sep 23, 2021

The python module oracle_sql does in line 232 a split using sqldelim as delimeter:

232:             sql = sqlfile.split(sqldelim)

This split does not care for quoted strings.
It is needed to fix this in order to be able to process sql files containing / or ; characters inside quoted blocks.
I have a fix available and can make a PR in a bit.
bartowl added a commit to bartowl/ansible-oracle that referenced this issue Sep 23, 2021
@bartowl
fix for quoted sqldelim fixes opitzconsulting#68
bbab9ff
@bartowl bartowl mentioned this issue Sep 23, 2021
Merged
Rendanic added a commit that referenced this issue Sep 23, 2021
@Rendanic
Merge pull request #69 from bartowl/fix_68
00a0491 
fix for quoted sqldelim fixes #68
@Rendanic Rendanic mentioned this issue Oct 10, 2021
Merged
Rendanic added a commit to opitzconsulting/ansible-oracle-modules that referenced this issue Oct 10, 2021
@Rendanic
Merge pull request #12 from Rendanic/proraclesql
fd3ecb4 
fix for quoted sqldelim fixes #opitzconsulting/ansible-oracle/issues/68
Rendanic pushed a commit that referenced this issue Jul 10, 2022
@bartowl @Rendanic
fix for quoted sqldelim fixes #68
2cce28e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for quoted sqldelim fixes #68 bartowl/ansible-oracle
1 participant
@bartowl