Skip to content

Commit

Permalink
oraasm-createdg: ansible-lint
Browse files Browse the repository at this point in the history
  • Loading branch information
Rendanic committed Sep 12, 2021
1 parent 0c2178d commit e68db7d
Show file tree
Hide file tree
Showing 3 changed files with 93 additions and 82 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ansible-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
targets: |
roles/common
roles/cxoracle
roles/oraasm-createdg
roles/oraasm-manage-diskgroups
roles/oradb-datapatch
roles/oradb-manage-db
Expand Down
82 changes: 41 additions & 41 deletions roles/oraasm-createdg/defaults/main.yml
Original file line number Diff line number Diff line change
@@ -1,44 +1,44 @@
---

old_diskgroup_config: True
oracle_user: oracle
grid_user: grid
grid_install_user: "{% if role_separation %}{{ grid_user }}{% else %}{{ oracle_user }}{% endif %}"
oracle_group: oinstall
oracle_base: /u01/app/oracle
oracle_home_gi: "{% if configure_cluster %}{{ oracle_home_gi_cl }}{% else %}{{ oracle_home_gi_so }}{% endif %}"
oracle_home_gi_cl: "/u01/app/{{ oracle_install_version_gi }}/grid" # ORACLE_HOME for Grid Infrastructure (Clustered)
oracle_home_gi_so: "{{ oracle_base }}/{{ oracle_install_version_gi }}/grid" # ORACLE_HOME for Grid Infrastructure (Stand Alone)
oracle_stage: /u01/stage
oracle_rsp_stage: "{{ oracle_stage }}/rsp"
oracle_stage_remote: "{{ oracle_stage }}"
device_persistence: asmlib
oracle_asm_disk_string: "{% if device_persistence == 'asmlib' %}{% elif device_persistence == 'udev' %}/dev/oracle/{% else %}{% endif %}"
old_diskgroup_config: true
oracle_user: oracle
grid_user: grid
grid_install_user: "{% if role_separation %}{{ grid_user }}{% else %}{{ oracle_user }}{% endif %}"
oracle_group: oinstall
oracle_base: /u01/app/oracle
oracle_home_gi: "{% if configure_cluster %}{{ oracle_home_gi_cl }}{% else %}{{ oracle_home_gi_so }}{% endif %}"
oracle_home_gi_cl: "/u01/app/{{ oracle_install_version_gi }}/grid" # ORACLE_HOME for Grid Infrastructure (Clustered)
oracle_home_gi_so: "{{ oracle_base }}/{{ oracle_install_version_gi }}/grid" # ORACLE_HOME for Grid Infrastructure (Stand Alone)
oracle_stage: /u01/stage
oracle_rsp_stage: "{{ oracle_stage }}/rsp"
oracle_stage_remote: "{{ oracle_stage }}"
device_persistence: asmlib
oracle_asm_disk_string: "{% if device_persistence == 'asmlib' %}{% elif device_persistence == 'udev' %}/dev/oracle/{% else %}{% endif %}"

# asm_diskgroups:
# - diskgroup: crs
# properties:
# - {redundancy: normal, ausize: 1}
# attributes:
# - {name: 'compatible.rdbms', value: 11.2.0.4.0}
# - {name: 'compatible.asm', value: 12.1.0.2.0}
# disk:
# - {device: /dev/sdc, asmlabel: crs01}
# - {device: /dev/sdd, asmlabel: crs02}
# - {device: /dev/sde, asmlabel: crs03}
# - diskgroup: data
# properties:
# - {redundancy: external, ausize: 4}
# attributes:
# - {name: compatible.rdbms, value: 11.2.0.4.0}
# - {name: compatible.asm, value: 12.1.0.2.0}
# disk:
# - {device: /dev/sdf, asmlabel: data01}
# - diskgroup: fra
# properties:
# - {redundancy: external, ausize: 4}
# attributes:
# - {name: compatible.rdbms, value: 11.2.0.4.0}
# - {name: compatible.asm, value: 12.1.0.2.0}
# disk:
# - {device: /dev/sdg, asmlabel: fra01}
# asm_diskgroups:
# - diskgroup: crs
# properties:
# - {redundancy: normal, ausize: 1}
# attributes:
# - {name: 'compatible.rdbms', value: 11.2.0.4.0}
# - {name: 'compatible.asm', value: 12.1.0.2.0}
# disk:
# - {device: /dev/sdc, asmlabel: crs01}
# - {device: /dev/sdd, asmlabel: crs02}
# - {device: /dev/sde, asmlabel: crs03}
# - diskgroup: data
# properties:
# - {redundancy: external, ausize: 4}
# attributes:
# - {name: compatible.rdbms, value: 11.2.0.4.0}
# - {name: compatible.asm, value: 12.1.0.2.0}
# disk:
# - {device: /dev/sdf, asmlabel: data01}
# - diskgroup: fra
# properties:
# - {redundancy: external, ausize: 4}
# attributes:
# - {name: compatible.rdbms, value: 11.2.0.4.0}
# - {name: compatible.asm, value: 12.1.0.2.0}
# disk:
# - {device: /dev/sdg, asmlabel: fra01}
92 changes: 51 additions & 41 deletions roles/oraasm-createdg/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,48 +1,58 @@
---

- name: ASMCA | Create script to build asm-diskgroups
template: src=asmca-createdg.sh.j2 dest="{{ oracle_rsp_stage }}/asmca-createdg-{{ item.diskgroup }}.sh" owner="{{ grid_install_user }}" group={{ oracle_group }} mode=744 backup=yes
with_items: "{{asm_diskgroups}}"
run_once: "{{ configure_cluster}}"
when: item.diskgroup != oracle_asm_init_dg and asm_diskgroups is defined
tags: asmcaa
- name: ASMCA | Create script to build asm-diskgroups
template:
src=asmca-createdg.sh.j2
dest="{{ oracle_rsp_stage }}/asmca-createdg-{{ item.diskgroup }}.sh"
owner="{{ grid_install_user }}"
group={{ oracle_group }}
mode=0744
backup=true
with_items: "{{ asm_diskgroups }}"
run_once: "{{ configure_cluster }}"
when: item.diskgroup != oracle_asm_init_dg and asm_diskgroups is defined
tags: asmcaa

- name: ASMCA | Create ASM diskgroups
shell: "{{ oracle_rsp_stage }}/asmca-createdg-{{ item.diskgroup }}.sh"
with_items: "{{asm_diskgroups}}"
become: yes
become_user: "{{ grid_install_user }}"
run_once: "{{ configure_cluster}}"
when: item.diskgroup != oracle_asm_init_dg and asm_diskgroups is defined
ignore_errors: True
tags: asmca
register: asmca
- name: ASMCA | Create ASM diskgroups
shell: "{{ oracle_rsp_stage }}/asmca-createdg-{{ item.diskgroup }}.sh"
# noqa command-instead-of-shell
with_items: "{{ asm_diskgroups }}"
become: true
become_user: "{{ grid_install_user }}"
run_once: "{{ configure_cluster }}"
when: item.diskgroup != oracle_asm_init_dg and asm_diskgroups is defined
ignore_errors: true
tags: asmca
register: asmca

- name: Print Results
debug: var=item
with_items:
- "{{ asmca.results|map(attribute='stdout_lines')|list }}"
run_once: "{{ configure_cluster}}"
#when: master_node
ignore_errors: true
tags: asmca
- name: Print Results
# noqa ignore-errors
debug: var=item
with_items:
- "{{ asmca.results|map(attribute='stdout_lines')|list }}"
run_once: "{{ configure_cluster }}"
# when: master_node
ignore_errors: true
tags: asmca

- name: ASMCA | List ASM diskgroups
shell: "{{ oracle_home_gi }}/bin/srvctl status diskgroup -g {{ item.diskgroup }}"
with_items: "{{asm_diskgroups}}"
become: yes
become_user: "{{ grid_install_user }}"
run_once: "{{ configure_cluster}}"
when: asm_diskgroups is defined
tags: srvctlasm
register: srvctlasm
- name: ASMCA | List ASM diskgroups
shell: "{{ oracle_home_gi }}/bin/srvctl status diskgroup -g {{ item.diskgroup }}"
# noqa command-instead-of-shell
with_items: "{{ asm_diskgroups }}"
become: true
become_user: "{{ grid_install_user }}"
run_once: "{{ configure_cluster }}"
when: asm_diskgroups is defined
tags: srvctlasm
register: srvctlasm


- name: list diskgroups
debug: var=item
with_items:
- "{{ srvctlasm.results|map(attribute='stdout_lines')|list }}"
run_once: "{{ configure_cluster}}"
when: asm_diskgroups is defined
ignore_errors: true
tags: srvctlasm
- name: list diskgroups
# noqa ignore-errors
debug: var=item
with_items:
- "{{ srvctlasm.results|map(attribute='stdout_lines')|list }}"
run_once: "{{ configure_cluster }}"
when: asm_diskgroups is defined
ignore_errors: true
tags: srvctlasm

0 comments on commit e68db7d

Please sign in to comment.