Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fail on go code #76

Merged
merged 1 commit into from
Oct 20, 2022
Merged

ci: fail on go code #76

merged 1 commit into from
Oct 20, 2022

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Oct 20, 2022

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb requested a review from a team as a code owner October 20, 2022 13:04
@@ -68,4 +68,15 @@ jq -r .\"ietf-sztp-conveyed-info:onboarding-information\".\"boot-image\".\"image
# print for debug
docker-compose ps

# test go-code
sleep 30
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will replace split with something more intelligent in the next PR

Copy link
Contributor

@mestery mestery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, especially with the upcoming removal of the sleep call. ;)

Copy link
Contributor

@alknopfler alknopfler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glimchb glimchb merged commit ba75982 into opiproject:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants