implementation of daemon option in agent #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alberto Morgante Medina <alknopfler@users.noreply.github.com>
Signed-off-by: Alberto Morgante Medina <alknopfler@users.noreply.github.com>
Signed-off-by: Alberto Morgante Medina <alknopfler@users.noreply.github.com>
Signed-off-by: Alberto Morgante Medina <alknopfler@users.noreply.github.com>
Signed-off-by: Alberto Morgante Medina <alknopfler@users.noreply.github.com>
Signed-off-by: Alberto Morgante Medina <alknopfler@users.noreply.github.com>
Signed-off-by: Alberto Morgante Medina <alknopfler@users.noreply.github.com>
glimchb
reviewed
Oct 10, 2022
| func (a *Agent) prepareEnvDaemon() error { | ||
| log.Println("[INFO] Get the Bootstrap URL from DHCP client") | ||
|
|
||
| if _, err := os.Stat(DHCLIENT_LEASE_FILE); err == nil { |
There was a problem hiding this comment.
you need to do this in a loop, because it takes time to get a lease from DHCP server...
glimchb
reviewed
Oct 10, 2022
| ) | ||
|
|
||
| const ( | ||
| DHCLIENT_LEASE_FILE = "/var/lib/dhclient/dhclient.leases" |
There was a problem hiding this comment.
we might do it a separate file so we can have logic for both: DHCP, mDNS and SLAAC
wdyt ?
There was a problem hiding this comment.
WDYM?
instead of the loop looking this:
if _, err := os.Stat(DHCLIENT_LEASE_FILE); err == nil {
line := linesInFileContains(DHCLIENT_LEASE_FILE, SZTP_REDIRECT_URL)
a.BootstrapURL = extractURLfromLine(line, `(?m)[^"]*`)
log.Println(a)
have a function to look 3 sources (dhclient.leases, slaac and mdns) to know where's the change and continue with this change?
Signed-off-by: Alberto Morgante Medina <alknopfler@users.noreply.github.com>
glimchb
approved these changes
Oct 11, 2022
glimchb
changed the title
Signed-off-by: Alberto Morgante Medina <alknopfler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains: