Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more tests to daemon and the rest of files #120

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

alknopfler
Copy link
Contributor

@alknopfler alknopfler commented Nov 11, 2022

Adding more tests to daemon and other files:
83.2% coverage reached

Signed-off-by: Alberto Morgante Medina alknopfler@users.noreply.github.com

Signed-off-by: Alberto Morgante Medina <alknopfler@users.noreply.github.com>
@alknopfler alknopfler requested a review from a team as a code owner November 11, 2022 12:46
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #120 (c7bd8c5) into main (0289280) will increase coverage by 36.56%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #120       +/-   ##
===========================================
+ Coverage   46.06%   82.63%   +36.56%     
===========================================
  Files           7       12        +5     
  Lines         432      570      +138     
===========================================
+ Hits          199      471      +272     
+ Misses        229       80      -149     
- Partials        4       19       +15     
Impacted Files Coverage Δ
sztp-agent/pkg/secureagent/daemon.go 69.09% <100.00%> (+38.19%) ⬆️
sztp-agent/cmd/enable.go 85.71% <0.00%> (ø)
sztp-agent/cmd/disable.go 85.18% <0.00%> (ø)
sztp-agent/cmd/run.go 85.71% <0.00%> (ø)
sztp-agent/cmd/status.go 85.71% <0.00%> (ø)
sztp-agent/cmd/daemon.go 85.18% <0.00%> (ø)
sztp-agent/pkg/secureagent/agent.go 100.00% <0.00%> (+50.00%) ⬆️
sztp-agent/pkg/secureagent/run.go 100.00% <0.00%> (+100.00%) ⬆️
sztp-agent/pkg/secureagent/enable.go 100.00% <0.00%> (+100.00%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, more testing!!!

@glimchb glimchb merged commit 79d04e5 into opiproject:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants