Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests check used uniformly with other bridges #321

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Tests check used uniformly with other bridges #321

merged 6 commits into from
Jul 18, 2023

Conversation

artek-koltun
Copy link
Contributor

@artek-koltun artek-koltun commented Jul 18, 2023 •
edited
Loading

@artek-koltun
update opi-spdk-bridge to 1c476f8b
2d8c7bf 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
use test response check uniformly for nvme controller
c35290a 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
use test response check uniformly for nvme namespace
a65a418 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
use test response check uniformly for nvme subsystem
66cf05a 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
use test response check uniformly for virtio-blk
539a09a 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
use tt as test case name
e1a7c82 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #321 (e1a7c82) into main (e66e0e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files           5        5           
  Lines         875      875           
=======================================
  Hits          732      732           
  Misses        108      108           
  Partials       35       35

@artek-koltun artek-koltun changed the title Tests uniformly check nil Tests check used uniformly with other bridges Jul 18, 2023
@artek-koltun artek-koltun marked this pull request as ready for review July 18, 2023 08:32
@artek-koltun artek-koltun requested a review from a team as a code owner July 18, 2023 08:32
glimchb
glimchb approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great code unification and simplification

@glimchb glimchb merged commit 9607348 into opiproject:main Jul 18, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artek-koltun @glimchb