Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the diagrams for new configuration changes #77

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

venkatmahalingam
Copy link
Member

Updated the diagrams for new configuration changes

@venkatmahalingam venkatmahalingam requested a review from a team as a code owner July 28, 2023 15:51
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #77 (d6aa69b) into main (74ea399) will increase coverage by 1.01%.
Report is 9 commits behind head on main.
The diff coverage is n/a.

❗ Current head d6aa69b differs from pull request most recent head efb12cc. Consider uploading reports for the commit efb12cc to get more accurate results

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   34.23%   35.24%   +1.01%     
==========================================
  Files           5        5              
  Lines         739      732       -7     
==========================================
+ Hits          253      258       +5     
+ Misses        465      453      -12     
  Partials       21       21              

see 5 files with indirect coverage changes

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mardim91 please review

@venkatmahalingam
Copy link
Member Author

venkatmahalingam commented Jul 28, 2023

@mardim91 I'll have to look at why access link case is not working for VLAN50 from host1, for now, I made it as trunk, will fix it. #78

@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Jul 28, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I believe in the first bubble you want destMac: vlan40-SVI-GW-MAC-LEAF1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we could change it for better clarity.

@mardim91
Copy link
Contributor

mardim91 commented Aug 2, 2023

@venkatmahalingam please add also the detailed picture of the packet flow for the L3VNI usecases for vlan 50 which is an access vlan.

@venkatmahalingam
Copy link
Member Author

Please ignore the commitline failure, will squash the commits once I get go ahead from @mardim91

Copy link
Contributor

@mardim91 mardim91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If anything seems off we can update again in the future. For now looks ok

Thank you @venkatmahalingam

Signed-off-by: Venkatesan Mahalingam <Venkatesan.Mahalinga@dell.com>
@glimchb glimchb merged commit 0bca71f into opiproject:main Aug 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants