-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the diagrams for new configuration changes #77
Conversation
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 34.23% 35.24% +1.01%
==========================================
Files 5 5
Lines 739 732 -7
==========================================
+ Hits 253 258 +5
+ Misses 465 453 -12
Partials 21 21 |
bf836db
to
f3799d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mardim91 please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I believe in the first bubble you want destMac: vlan40-SVI-GW-MAC-LEAF1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we could change it for better clarity.
@venkatmahalingam please add also the detailed picture of the packet flow for the L3VNI usecases for vlan 50 which is an access vlan. |
Please ignore the commitline failure, will squash the commits once I get go ahead from @mardim91 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If anything seems off we can update again in the future. For now looks ok
Thank you @venkatmahalingam
Signed-off-by: Venkatesan Mahalingam <Venkatesan.Mahalinga@dell.com>
Updated the diagrams for new configuration changes