Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRF: move from cloud APIs to evpn-gw APIs #66

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Jul 13, 2023

  • Note the collapse of CreateTunnel and CreateSubnet into CreateVrf
  • Note RouteTable and BridgeMac are randomly generated now

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

@glimchb glimchb requested a review from a team July 13, 2023 21:06
@glimchb glimchb force-pushed the main branch 2 times, most recently from 2f8af5c to 558dee6 Compare July 13, 2023 21:13
@glimchb glimchb changed the title VRF: move from cloud APIs to evpngw APIs VRF: move from cloud APIs to evpn-gw APIs Jul 13, 2023
@glimchb glimchb force-pushed the main branch 3 times, most recently from 9eab3d2 to 522e181 Compare July 13, 2023 21:27
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #66 (b9b793e) into main (1a96d32) will decrease coverage by 2.65%.
The diff coverage is 21.87%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   36.88%   34.23%   -2.65%     
==========================================
  Files           5        5              
  Lines         686      739      +53     
==========================================
  Hits          253      253              
- Misses        412      465      +53     
  Partials       21       21              
Impacted Files Coverage Δ
pkg/evpn/svi_subnet.go 35.26% <0.00%> (ø)
pkg/evpn/evpn.go 52.94% <11.11%> (-47.06%) ⬇️
pkg/evpn/vrf.go 32.44% <23.25%> (-10.22%) ⬇️

@glimchb glimchb marked this pull request as ready for review July 13, 2023 21:47
@glimchb glimchb requested a review from a team as a code owner July 13, 2023 21:47
cmd/main.go Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
pkg/evpn/svi_subnet.go Show resolved Hide resolved
pkg/evpn/svi_subnet_test.go Show resolved Hide resolved
pkg/evpn/vrf.go Show resolved Hide resolved
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb force-pushed the main branch 2 times, most recently from f06e310 to 4828d4f Compare July 20, 2023 17:03
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
As agreed on the OPI commiunity meeting

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
README.md Show resolved Hide resolved
pkg/evpn/vrf.go Show resolved Hide resolved
pkg/evpn/vrf.go Show resolved Hide resolved
fmt.Printf("Failed to add Bridge to VRF: %v", err)
return nil, err
}
// Example: ip link set br100 addr aa:bb:cc:00:00:02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ip link set br100 addr aa:bb:cc:00:00:02 type bridge

I think this is the correct command. Not sure if there is any difference. This is for setting the router MAC I believe

fmt.Printf("Failed to up Bridge link: %v", err)
return nil, err
}
// Example: ip link add vni100 type vxlan local 10.0.0.4 dstport 4789 id 100 nolearning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ip link add vni100 type vxlan local 10.0.0.4 dstport 4789 id 100 nolearning proxy

I think this is the right command.

fmt.Printf("Failed to create Vxlan link: %v", err)
return nil, err
}
// Example: ip link set vni100 master br100 addrgenmode none
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ip link set vni100 master br100

This is the command that we have used. Not sure if the difference plays a role.

@glimchb glimchb merged commit f10e579 into opiproject:main Jul 24, 2023
15 of 18 checks passed
@glimchb
Copy link
Member Author

glimchb commented Jul 24, 2023

Merging this PR and opened few issues to address the gaps from the code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants