VRF: move from cloud APIs to evpn-gw APIs
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glimchb
force-pushed
the
main
branch
2 times, most recently
from
2f8af5c
to
558dee6
Compare
glimchb
changed the title
cloud APIs to evpn-gw APIs
glimchb
force-pushed
the
main
branch
3 times, most recently
from
9eab3d2
to
522e181
Compare
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 36.88% 34.23% -2.65%
==========================================
Files 5 5
Lines 686 739 +53
==========================================
Hits 253 253
- Misses 412 465 +53
Partials 21 21
|
mardim91
reviewed
Jul 17, 2023
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
force-pushed
the
main
branch
2 times, most recently
from
f06e310
to
4828d4f
Compare
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
As agreed on the OPI commiunity meeting Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
requested review from
venkatmahalingam,
jainvipin,
sandersms and
mardim91
mardim91
reviewed
Jul 24, 2023
| fmt.Printf("Failed to add Bridge to VRF: %v", err) | ||
| return nil, err | ||
| } | ||
| // Example: ip link set br100 addr aa:bb:cc:00:00:02 |
There was a problem hiding this comment.
ip link set br100 addr aa:bb:cc:00:00:02 type bridge
I think this is the correct command. Not sure if there is any difference. This is for setting the router MAC I believe
| fmt.Printf("Failed to up Bridge link: %v", err) | ||
| return nil, err | ||
| } | ||
| // Example: ip link add vni100 type vxlan local 10.0.0.4 dstport 4789 id 100 nolearning |
There was a problem hiding this comment.
ip link add vni100 type vxlan local 10.0.0.4 dstport 4789 id 100 nolearning proxy
I think this is the right command.
| fmt.Printf("Failed to create Vxlan link: %v", err) | ||
| return nil, err | ||
| } | ||
| // Example: ip link set vni100 master br100 addrgenmode none |
There was a problem hiding this comment.
ip link set vni100 master br100
This is the command that we have used. Not sure if the difference plays a role.
This was referenced Jul 24, 2023
|
Merging this PR and opened few issues to address the gaps from the code review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateTunnelandCreateSubnetintoCreateVrfSigned-off-by: Boris Glimcher Boris.Glimcher@emc.com