feat(idpool): idpool feature for generating id's #400
Conversation
pkg/LinuxGeneralModule/lgm.go
Outdated
| @@ -465,8 +467,12 @@ func setUpVrf(vrf *infradb.Vrf) (string, bool) { | |||
| vrf.Metadata.RoutingTable = make([]*uint32, 1) | |||
| vrf.Metadata.RoutingTable[0] = new(uint32) | |||
| var routingTable uint32 | |||
| Name := vrf.Name | |||
There was a problem hiding this comment.
please align with Go style guide:
https://google.github.io/styleguide/go/decisions.html
There was a problem hiding this comment.
I think you overshot it :)
why _unusedids? It is almost unreadable. Use lower case for not exported members. Use camelCase naming. Do not use _ in names.
pkg/utils/Idpool.go
Outdated
| _unusedIDs []uint32 // Yet unused IDs in pool Available ids | ||
| _idsInUse map[interface{}]uint32 // Mapping key: id for currently assigned ids | ||
| _idsForReuse map[interface{}]uint32 // Mapping key: id for previously assigned ids | ||
| _refs map[uint32][]interface{} |
There was a problem hiding this comment.
refs sounds like a counter tracking how many times we requested the same id, no?
There was a problem hiding this comment.
correct, its reference to the same id
There was a problem hiding this comment.
then why do we need a slice of slices then? Can we have a slice of counters? map[uint32]uint32?
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
3 times, most recently
from
eb45583
to
45ace4d
Compare
pkg/utils/idpool.go
Outdated
| // Copyright (c) 2022-2023 Intel Corporation, or its subsidiaries. | ||
| // Copyright (C) 2023 Nordix Foundation. | ||
|
|
||
| // Package linuxgeneralmodule is the main package of the application |
pkg/utils/Idpool.go
Outdated
| if len(ip._unusedIDs) != 0 { | ||
| // Pick an unused id | ||
| id = ip._unusedIDs[0] | ||
| ip._unusedIDs = append(ip._unusedIDs[:0], ip._unusedIDs[1:]...) |
There was a problem hiding this comment.
you are still picking the first element from the slice, which is suboptimal? If you reverse your unused id in init and will pick last element (which is more effective)?
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
2 times, most recently
from
322f68f
to
9bfa71a
Compare
Signed-off-by: Venkatesh, Vemula <venkatesh.vemula@intel.com> Signed-off-by: Atul Patel <Atul.Patel@intel.com>
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
from
9bfa71a
to
d04f716
Compare
Signed-off-by: Vemula Venkatesh <venkatesh.vemula@intel.com>
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
from
ed77db5
to
f0058be
Compare
Signed-off-by: Vemula Venkatesh <venkatesh.vemula@intel.com>
idpool feature for generating id's for mod pointer, routing table id , trie pointer.