-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(evpn-bridge): intel e2000 vendor plugin #386
feat(evpn-bridge): intel e2000 vendor plugin #386
Conversation
9b87625
to
fab3989
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder is this is better to implement vendor plugin in their own repos and then import them here and use. we can't really maintain/code review that many plugins...
fab3989
to
c5ec66a
Compare
Hello @glimchb, This is something that is our intention too. So we plan to do this in the future. We thought that is basic easier for now that we are implementing the whole rearchitecture thing and we test everything to put everything in one repo. When the main work is done then we can create different repos for the vendor plugins and inject them from there but for now let's keep everyhting in one place because that helps on the testing and doesn't introduce any extra integration effort. I can open an issue to track this if you want |
c5ec66a
to
a4d4c3a
Compare
a4d4c3a
to
1f95452
Compare
Co-authored-by: Vemula Venkatesh <venkatesh.vemula@intel.com> Co-authored-by: Saikumar Banoth <banoth.saikumar@intel.com> Co-authored-by: Jambekar Vishakha <vishakha.jambekar@intel.com> Co-authored-by: Dimitrios Markou <dimitrios.markou@ericsson.com> Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
1f95452
to
0a6d34b
Compare
Hello @glimchb I have noticed that you have putted an "invalid" tag on this PR. What does that exactly mean? can you please explain ? |
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
f457b80
to
7c3f26b
Compare
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 50.77% 44.31% -6.46%
==========================================
Files 37 25 -12
Lines 2525 1663 -862
==========================================
- Hits 1282 737 -545
+ Misses 1114 838 -276
+ Partials 129 88 -41 ☔ View full report in Codecov by Sentry. |
has been moved to opi-intel-bridge |
No description provided.