Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evpn-bridge): intel e2000 vendor plugin #386

Closed

Conversation

atulpatel261194
Copy link
Contributor

No description provided.

@atulpatel261194 atulpatel261194 requested a review from a team as a code owner May 20, 2024 07:01
@atulpatel261194 atulpatel261194 force-pushed the drop1.0Intele2000VendorPlugin branch 4 times, most recently from 9b87625 to fab3989 Compare May 23, 2024 18:42
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder is this is better to implement vendor plugin in their own repos and then import them here and use. we can't really maintain/code review that many plugins...

@mardim91
Copy link
Contributor

I wonder is this is better to implement vendor plugin in their own repos and then import them here and use. we can't really maintain/code review that many plugins...

Hello @glimchb,

This is something that is our intention too. So we plan to do this in the future. We thought that is basic easier for now that we are implementing the whole rearchitecture thing and we test everything to put everything in one repo. When the main work is done then we can create different repos for the vendor plugins and inject them from there but for now let's keep everyhting in one place because that helps on the testing and doesn't introduce any extra integration effort.

I can open an issue to track this if you want

@glimchb glimchb added the invalid This doesn't seem right label Jun 10, 2024
Co-authored-by: Vemula Venkatesh <venkatesh.vemula@intel.com>
Co-authored-by: Saikumar Banoth <banoth.saikumar@intel.com>
Co-authored-by: Jambekar Vishakha <vishakha.jambekar@intel.com>
Co-authored-by: Dimitrios Markou <dimitrios.markou@ericsson.com>
Signed-off-by: atulpatel261194 <Atul.Patel@intel.com>
@mardim91
Copy link
Contributor

Hello @glimchb

I have noticed that you have putted an "invalid" tag on this PR. What does that exactly mean? can you please explain ?

Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
@Inbanoth Inbanoth force-pushed the drop1.0Intele2000VendorPlugin branch from f457b80 to 7c3f26b Compare July 2, 2024 11:18
Signed-off-by: Saikumar, Banoth <banoth.saikumar@intel.com>
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.31%. Comparing base (5440fb9) to head (17a048a).
Report is 48 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (5440fb9) and HEAD (17a048a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5440fb9) HEAD (17a048a)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   50.77%   44.31%   -6.46%     
==========================================
  Files          37       25      -12     
  Lines        2525     1663     -862     
==========================================
- Hits         1282      737     -545     
+ Misses       1114      838     -276     
+ Partials      129       88      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atulpatel261194
Copy link
Contributor Author

has been moved to opi-intel-bridge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants