Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(port): add more mock tests #157

Merged
merged 1 commit into from
Sep 6, 2023
Merged

test(port): add more mock tests #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/evpn/bridge_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ func Test_CreateLogicalBridge(t *testing.T) {
in: &testLogicalBridge,
out: nil,
errCode: codes.NotFound,
errMsg: "unable to find key br-tenant",
errMsg: fmt.Sprintf("unable to find key %v", tenantbridgeName),
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(nil, errors.New(errMsg)).Once()
Expand Down
146 changes: 142 additions & 4 deletions pkg/evpn/port_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@ import (
"errors"
"fmt"
"log"
"net"
"reflect"
"testing"

"github.com/stretchr/testify/mock"
"github.com/vishvananda/netlink"

"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/credentials/insecure"
Expand All @@ -33,7 +37,7 @@ var (
Spec: &pb.BridgePortSpec{
MacAddress: []byte{0xCB, 0xB8, 0x33, 0x4C, 0x88, 0x4F},
Ptype: pb.BridgePortType_TRUNK,
LogicalBridges: []string{"Japan", "Australia", "Germany"},
LogicalBridges: []string{testLogicalBridgeName},
},
}
)
Expand Down Expand Up @@ -110,21 +114,154 @@ func Test_CreateBridgePort(t *testing.T) {
},
out: nil,
errCode: codes.InvalidArgument,
errMsg: fmt.Sprintf("ACCESS type must have single LogicalBridge and not (%d)", len(testBridgePort.Spec.LogicalBridges)),
errMsg: fmt.Sprintf("ACCESS type must have single LogicalBridge and not (%d)", 3),
exist: false,
on: nil,
},
"failed LinkByName call": {
"failed LinkByName bridge call": {
id: testBridgePortID,
in: &testBridgePort,
out: nil,
errCode: codes.NotFound,
errMsg: "unable to find key br-tenant",
errMsg: fmt.Sprintf("unable to find key %v", tenantbridgeName),
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(nil, errors.New(errMsg)).Once()
},
},
"failed LinkByName port call": {
id: testBridgePortID,
in: &testBridgePort,
out: nil,
errCode: codes.NotFound,
errMsg: fmt.Sprintf("unable to find key %v", testBridgePortID),
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
mockNetlink.EXPECT().LinkByName(testBridgePortID).Return(nil, errors.New(errMsg)).Once()
},
},
"failed LinkSetHardwareAddr call": {
id: testBridgePortID,
in: &testBridgePort,
out: nil,
errCode: codes.Unknown,
errMsg: "Failed to call LinkSetHardwareAddr",
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
iface := &netlink.Dummy{LinkAttrs: netlink.LinkAttrs{Name: testBridgePortID}}
mockNetlink.EXPECT().LinkByName(testBridgePortID).Return(iface, nil).Once()
mac := net.HardwareAddr(testBridgePort.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(iface, mac).Return(errors.New(errMsg)).Once()
},
},
"failed bridge LinkSetMaster call": {
id: testBridgePortID,
in: &testBridgePort,
out: nil,
errCode: codes.Unknown,
errMsg: "Failed to call LinkSetMaster",
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
iface := &netlink.Dummy{LinkAttrs: netlink.LinkAttrs{Name: testBridgePortID}}
mockNetlink.EXPECT().LinkByName(testBridgePortID).Return(iface, nil).Once()
mac := net.HardwareAddr(testBridgePort.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(iface, mac).Return(nil).Once()
mockNetlink.EXPECT().LinkSetMaster(mock.Anything, mock.Anything).Return(errors.New(errMsg)).Once()
},
},
"missing bridges": {
id: testBridgePortID,
in: &pb.BridgePort{
Spec: &pb.BridgePortSpec{
MacAddress: []byte{0xCB, 0xB8, 0x33, 0x4C, 0x88, 0x4F},
Ptype: pb.BridgePortType_TRUNK,
LogicalBridges: []string{"Japan", "Australia", "Germany"},
},
},
out: nil,
errCode: codes.NotFound,
errMsg: fmt.Sprintf("unable to find key %v", "Japan"),
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
iface := &netlink.Dummy{LinkAttrs: netlink.LinkAttrs{Name: testBridgePortID}}
mockNetlink.EXPECT().LinkByName(testBridgePortID).Return(iface, nil).Once()
mac := net.HardwareAddr(testBridgePort.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(iface, mac).Return(nil).Once()
mockNetlink.EXPECT().LinkSetMaster(iface, bridge).Return(nil).Once()
},
},
"failed BridgeVlanAdd TRUNK call": {
id: testBridgePortID,
in: &testBridgePort,
out: nil,
errCode: codes.Unknown,
errMsg: "Failed to call BridgeVlanAdd",
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
iface := &netlink.Dummy{LinkAttrs: netlink.LinkAttrs{Name: testBridgePortID}}
mockNetlink.EXPECT().LinkByName(testBridgePortID).Return(iface, nil).Once()
mac := net.HardwareAddr(testBridgePort.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(iface, mac).Return(nil).Once()
mockNetlink.EXPECT().LinkSetMaster(iface, bridge).Return(nil).Once()
vid := uint16(testLogicalBridge.Spec.VlanId)
mockNetlink.EXPECT().BridgeVlanAdd(iface, vid, false, false, false, false).Return(errors.New(errMsg)).Once()
},
},
"failed BridgeVlanAdd ACCESS call": {
id: testBridgePortID,
in: &pb.BridgePort{
Spec: &pb.BridgePortSpec{
MacAddress: []byte{0xCB, 0xB8, 0x33, 0x4C, 0x88, 0x4F},
Ptype: pb.BridgePortType_ACCESS,
LogicalBridges: []string{testLogicalBridgeName},
},
},
out: nil,
errCode: codes.Unknown,
errMsg: "Failed to call BridgeVlanAdd",
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
iface := &netlink.Dummy{LinkAttrs: netlink.LinkAttrs{Name: testBridgePortID}}
mockNetlink.EXPECT().LinkByName(testBridgePortID).Return(iface, nil).Once()
mac := net.HardwareAddr(testBridgePort.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(iface, mac).Return(nil).Once()
mockNetlink.EXPECT().LinkSetMaster(iface, bridge).Return(nil).Once()
vid := uint16(testLogicalBridge.Spec.VlanId)
mockNetlink.EXPECT().BridgeVlanAdd(iface, vid, true, true, false, false).Return(errors.New(errMsg)).Once()
},
},
"failed LinkSetUp call": {
id: testBridgePortID,
in: &testBridgePort,
out: nil,
errCode: codes.Unknown,
errMsg: "Failed to call LinkSetUp",
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
iface := &netlink.Dummy{LinkAttrs: netlink.LinkAttrs{Name: testBridgePortID}}
mockNetlink.EXPECT().LinkByName(testBridgePortID).Return(iface, nil).Once()
mac := net.HardwareAddr(testBridgePort.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(iface, mac).Return(nil).Once()
mockNetlink.EXPECT().LinkSetMaster(iface, bridge).Return(nil).Once()
vid := uint16(testLogicalBridge.Spec.VlanId)
mockNetlink.EXPECT().BridgeVlanAdd(iface, vid, false, false, false, false).Return(nil).Once()
mockNetlink.EXPECT().LinkSetUp(iface).Return(errors.New(errMsg)).Once()
},
},
}

// run tests
Expand All @@ -149,6 +286,7 @@ func Test_CreateBridgePort(t *testing.T) {
}(conn)
client := pb.NewBridgePortServiceClient(conn)

opi.Bridges[testLogicalBridgeName] = protoClone(&testLogicalBridge)
if tt.exist {
opi.Ports[testBridgePortName] = protoClone(&testBridgePort)
opi.Ports[testBridgePortName].Name = testBridgePortName
Expand Down
2 changes: 1 addition & 1 deletion pkg/evpn/svi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ func Test_CreateSvi(t *testing.T) {
in: &testSvi,
out: nil,
errCode: codes.NotFound,
errMsg: "unable to find key br-tenant",
errMsg: fmt.Sprintf("unable to find key %v", tenantbridgeName),
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(nil, errors.New(errMsg)).Once()
Expand Down
Loading