Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use mock.Anything to simplify tests #155

Closed
wants to merge 1 commit into from

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Sep 6, 2023

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #155 (f3a5cae) into main (977ae2b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   48.06%   48.06%           
=======================================
  Files           5        5           
  Lines         853      853           
=======================================
  Hits          410      410           
  Misses        424      424           
  Partials       19       19           

@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Sep 6, 2023
@glimchb
Copy link
Member Author

glimchb commented Sep 6, 2023

simplifying tests like this will cause them to be more weak, so deciding to abandon this change

@glimchb glimchb closed this Sep 6, 2023
@glimchb glimchb deleted the vtep branch September 6, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant