Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vrf): delete bridge and vxlan netdevs #121

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Aug 14, 2023

Fixes #120

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

@glimchb glimchb marked this pull request as ready for review August 14, 2023 16:38
@glimchb glimchb requested a review from a team as a code owner August 14, 2023 16:39
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #121 (14319a1) into main (e8c2c86) will decrease coverage by 1.52%.
The diff coverage is 0.00%.

❗ Current head 14319a1 differs from pull request most recent head 72e20bc. Consider uploading reports for the commit 72e20bc to get more accurate results

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   36.35%   34.84%   -1.52%     
==========================================
  Files           5        5              
  Lines         784      818      +34     
==========================================
  Hits          285      285              
- Misses        482      516      +34     
  Partials       17       17              
Files Changed Coverage Δ
pkg/evpn/vrf.go 28.50% <0.00%> (-5.00%) ⬇️

Fixes opiproject#120

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb merged commit 590edeb into opiproject:main Aug 14, 2023
16 of 17 checks passed
@glimchb glimchb deleted the ci branch August 14, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vrf: in delete function, also remove bridge and vxlan devices
2 participants