Moving the overlay networks to vlan aware bridge in leaf1 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 37.06% 37.06%
=======================================
Files 5 5
Lines 769 769
=======================================
Hits 285 285
Misses 467 467
Partials 17 17 |
Signed-off-by: Venkatesan Mahalingam <Venkatesan.Mahalinga@dell.com>
glimchb
added
the
Merge Candidate
glimchb
approved these changes
Aug 9, 2023
glimchb
reviewed
Aug 9, 2023
| bridge vlan add dev eth1 vid 40 && \ | ||
|
|
||
| ip addr flush dev eth2 && ip link set eth2 master br-tenant up && \ | ||
| bridge vlan add dev eth2 vid 50 && \ |
There was a problem hiding this comment.
this eth2 is supposed to be ACCESS, right ? need pvid untagged ?
glimchb
reviewed
Aug 9, 2023
| ip link set vlan40 master green up && \ | ||
| ip address add 40.40.40.1/24 dev vlan40 && \ | ||
|
|
||
| bridge vlan add dev br-tenant vid 50 self && \ |
There was a problem hiding this comment.
for vlan50 there is no corresponding vni40...
in grpc CreateSvi what can I pass as logical_bridge ?
is that a mistake ?
glimchb
reviewed
Aug 9, 2023
| ip link add blue type vrf table 1000 && \ | ||
| ip link set blue up && \ | ||
| ip link add name lo1 type dummy && \ | ||
| ip link set lo1 master blue up && \ |
There was a problem hiding this comment.
this code adds dummy iface
ip link add name lo1 type dummy && \
ip link set lo1 master blue up && \
ip address add 10.0.1.2/32 dev lo1 && \
is different from @mardim91 setting IP on the VRF itself...
ip address add 10.0.1.2/32 dev blue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been created from the PR #76