-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving the overlay networks to vlan aware bridge in leaf1 #102
Conversation
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 37.06% 37.06%
=======================================
Files 5 5
Lines 769 769
=======================================
Hits 285 285
Misses 467 467
Partials 17 17 |
Signed-off-by: Venkatesan Mahalingam <Venkatesan.Mahalinga@dell.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, seems like the previous closed PR just rebased
bridge vlan add dev eth1 vid 40 && \ | ||
|
||
ip addr flush dev eth2 && ip link set eth2 master br-tenant up && \ | ||
bridge vlan add dev eth2 vid 50 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this eth2
is supposed to be ACCESS
, right ? need pvid untagged
?
ip link set vlan40 master green up && \ | ||
ip address add 40.40.40.1/24 dev vlan40 && \ | ||
|
||
bridge vlan add dev br-tenant vid 50 self && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for vlan50
there is no corresponding vni40
...
in grpc CreateSvi
what can I pass as logical_bridge
?
is that a mistake ?
ip link add blue type vrf table 1000 && \ | ||
ip link set blue up && \ | ||
ip link add name lo1 type dummy && \ | ||
ip link set lo1 master blue up && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this code adds dummy iface
ip link add name lo1 type dummy && \
ip link set lo1 master blue up && \
ip address add 10.0.1.2/32 dev lo1 && \
is different from @mardim91 setting IP on the VRF itself...
ip address add 10.0.1.2/32 dev blue
This pull request has been created from the PR #76