fix: make br-tenant a constant

Fixes #100 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
opiproject · Aug 8, 2023 · e5b6895 · e5b6895
1 parent 837bd71
commit e5b6895
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/pkg/evpn/bridge.go b/pkg/evpn/bridge.go
@@ -61,10 +61,9 @@ func (s *Server) CreateLogicalBridge(_ context.Context, in *pb.CreateLogicalBrid
 	}
 	// create vxlan only if VNI is not empty
 	if in.LogicalBridge.Spec.Vni > 0 {
-		bridgeName := "br-tenant"
-		bridge, err := netlink.LinkByName(bridgeName)
+		bridge, err := netlink.LinkByName(tenantbridgeName)
 		if err != nil {
-			err := status.Errorf(codes.NotFound, "unable to find key %s", bridgeName)
+			err := status.Errorf(codes.NotFound, "unable to find key %s", tenantbridgeName)
 			log.Printf("error: %v", err)
 			return nil, err
 		}

diff --git a/pkg/evpn/evpn.go b/pkg/evpn/evpn.go
@@ -13,6 +13,10 @@ import (
 	pe "github.com/opiproject/opi-api/network/evpn-gw/v1alpha1/gen/go"
 )
 
+const (
+	tenantbridgeName = "br-tenant"
+)
+
 // Server represents the Server object
 type Server struct {
 	pb.UnimplementedCloudInfraServiceServer

diff --git a/pkg/evpn/port.go b/pkg/evpn/port.go
@@ -59,11 +59,9 @@ func (s *Server) CreateBridgePort(_ context.Context, in *pb.CreateBridgePortRequ
 		return nil, status.Errorf(codes.InvalidArgument, msg)
 	}
 	// not found, so create a new one
-	bridgeName := "br-tenant"
-	// get tenant bridge device by name
-	bridge, err := netlink.LinkByName(bridgeName)
+	bridge, err := netlink.LinkByName(tenantbridgeName)
 	if err != nil {
-		err := status.Errorf(codes.NotFound, "unable to find key %s", bridgeName)
+		err := status.Errorf(codes.NotFound, "unable to find key %s", tenantbridgeName)
 		log.Printf("error: %v", err)
 		return nil, err
 	}