-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[storage] [lint] Re-enable several rules #218
Conversation
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
import "object_key.proto"; | ||
import "uuid.proto"; | ||
|
||
// Back End (network-facing) APIs. This service is for AIO generic kernel block device. | ||
service AioControllerService { | ||
rpc CreateAioController (CreateAioControllerRequest) returns (AioController) { | ||
option (google.api.http) = { | ||
post: "/v1/subsystems" | ||
body: "subsystem" | ||
post: "/v1/{parent=subsystems}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't review URLs, they will be fixed here #188
import "object_key.proto"; | ||
import "uuid.proto"; | ||
|
||
// Back End (network-facing) APIs. This is debug interface for null block devices. | ||
service NullDebugService { | ||
rpc CreateNullDebug (CreateNullDebugRequest) returns (NullDebug) { | ||
option (google.api.http) = { | ||
post: "/v1/subsystems" | ||
body: "subsystem" | ||
post: "/v1/{parent=subsystems}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't review URLs, they will be fixed here #188
import "object_key.proto"; | ||
|
||
// Back End (network-facing) APIs. NVMe/TCP and NVMe/RoCEv2 protocols are covered by this service. | ||
service NVMfRemoteControllerService { | ||
rpc CreateNVMfRemoteController (CreateNVMfRemoteControllerRequest) returns (NVMfRemoteController) { | ||
option (google.api.http) = { | ||
post: "/v1/subsystems" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't review URLs, they will be fixed here #188
|
||
// Front End (host-facing) APIs. Mostly used for Virtio-scsi emulation and host presentation as alternative to Virtio-blk. | ||
service FrontendVirtioScsiService { | ||
rpc CreateVirtioScsiTarget (CreateVirtioScsiTargetRequest) returns (VirtioScsiTarget) { | ||
option (google.api.http) = { | ||
post: "/v1/virtioscsitargets" | ||
body: "virtioscsitarget" | ||
post: "/v1/{parent=subsystems}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't review URLs, they will be fixed here #188
|
||
// Front End (host-facing) APIs. Mostly used for Virtio-blk emulation emulation and host presentation as alternative to Nvme. | ||
service FrontendVirtioBlkService { | ||
rpc CreateVirtioBlk (CreateVirtioBlkRequest) returns (VirtioBlk) { | ||
option (google.api.http) = { | ||
post: "/v1/virtioblks" | ||
body: "virtioblk" | ||
post: "/v1/{parent=subsystems}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't review URLs, they will be fixed here #188
|
||
// Front End (host-facing) APIs. Mostly used for NVMe/PCIe emulation and host presentation. | ||
service FrontendNvmeService { | ||
rpc CreateNVMeSubsystem (CreateNVMeSubsystemRequest) returns (NVMeSubsystem) { | ||
option (google.api.http) = { | ||
post: "/v1/subsystems" | ||
body: "subsystem" | ||
post: "/v1/{parent=subsystems}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't review URLs, they will be fixed here #188
What are these new "parent" fields in the CreateXxx messages ? What is the API client supposed to put in this field ? |
good questions @llabordehpe
I just enabled the linters and fixed all errors reported there |
after this PR: