Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage] [backend] Add Handle to BE object now #217

Merged
merged 2 commits into from
Dec 7, 2022
Merged

[storage] [backend] Add Handle to BE object now #217

merged 2 commits into from
Dec 7, 2022

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Dec 6, 2022

Related to #174

Resource-oriented design https://google.aip.dev/121

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

@glimchb
[storage] [backend] Add Handle to BE object now
1bd5eee 
Related to opiproject#174

Resource-oriented design https://google.aip.dev/121

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb requested a review from a team as a code owner December 6, 2022 15:57
@glimchb glimchb added Storage APIs or code related to storage area Merge Candidate in the open merge window, next candidate for merge labels Dec 6, 2022
@glimchb glimchb self-assigned this Dec 6, 2022
mkalderon
mkalderon approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@mkalderon mkalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just two small questions. thanks

storage/v1alpha1/backend_nvme_tcp.proto
@@ -39,49 +44,37 @@ message NVMfRemoteControllerConnectRequest {
NVMfRemoteController ctrl = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not provide the objectKey here ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. according to what we did in frontend, we put the ID inside the object, so I wanted to align those here as well. From https://google.aip.dev/133#user-specified-ids indeed IDs should be in the request message, not the object and named string {resource}_id

storage/v1alpha1/backend_nvme_tcp.proto
}

message NVMfRemoteControllerListRequest {
int64 id = 1;
int32 page_size = 1;
string page_token = 2;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are these related to this pr ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could've split in 2 commits here, you are right.
the page fields are from https://google.aip.dev/132
just aligning the objects here from the frontend work we did

@jainvipin
Copy link
Contributor

we could go with using keys/handles and status/spec on backend objects as well.

@glimchb
Copy link
Member Author

glimchb commented Dec 6, 2022

we could go with using keys/handles and status/spec on backend objects as well.

yes, good idea

@glimchb
[storage] [backend] AIP Get/List/Create/Update/Delete rename
e4a471d 
See opiproject#174

Resource-oriented design https://google.aip.dev/121

for word in Get List Create Update Delete; do
  for i in AioController NullDebug NVMfRemoteController; do
    sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ;
  done;
done

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
glimchb commented Dec 6, 2022
View reviewed changes
storage/v1alpha1/backend_aio.proto
rpc AioControllerUpdate (AioControllerUpdateRequest) returns (AioController) {}
rpc CreateAioController (CreateAioControllerRequest) returns (AioController) {
option (google.api.http) = {
post: "/v1/subsystems"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs will be fixed #188

storage/v1alpha1/backend_null.proto
rpc NullDebugGet (NullDebugGetRequest) returns (NullDebug) {}
rpc CreateNullDebug (CreateNullDebugRequest) returns (NullDebug) {
option (google.api.http) = {
post: "/v1/subsystems"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs will be fixed #188

storage/v1alpha1/backend_nvme_tcp.proto
rpc NVMfRemoteControllerGet (NVMfRemoteControllerGetRequest) returns (NVMfRemoteControllerGetResponse) {}
rpc CreateNVMfRemoteController (CreateNVMfRemoteControllerRequest) returns (NVMfRemoteController) {
option (google.api.http) = {
post: "/v1/subsystems"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs will be fixed #188

sandersms
sandersms approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@glimchb glimchb merged commit fd93b84 into opiproject:main Dec 7, 2022
@glimchb glimchb deleted the crypto branch December 7, 2022 16:40
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this pull request Dec 7, 2022
@glimchb
[backend] AIP Get/List/Create/Update/Delete rename
761a360 
Resource-oriented design https://google.aip.dev/121

for word in Get List Create Update Delete; do
  for i in AioController NullDebug NVMfRemoteController; do
    sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ;
  done;
done

See opiproject/opi-api#217

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this pull request Dec 7, 2022
@glimchb
[backend] AIP Get/List/Create/Update/Delete rename
99d7959 
Resource-oriented design https://google.aip.dev/121

for word in Get List Create Update Delete; do
  for i in AioController NullDebug NVMfRemoteController; do
    sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ;
  done;
done

See opiproject/opi-api#217

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb mentioned this pull request Dec 7, 2022
Merged
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this pull request Dec 7, 2022
@glimchb
[backend] AIP Get/List/Create/Update/Delete rename
1f069fa 
Resource-oriented design https://google.aip.dev/121

for word in Get List Create Update Delete; do
  for i in AioController NullDebug NVMfRemoteController; do
    sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ;
  done;
done

See opiproject/opi-api#217

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this pull request Dec 7, 2022
@glimchb
[backend] AIP Get/List/Create/Update/Delete rename
430e5d8 
Resource-oriented design https://google.aip.dev/121

for word in Get List Create Update Delete; do
  for i in AioController NullDebug NVMfRemoteController; do
    sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ;
  done;
done

See opiproject/opi-api#217

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to opiproject/opi-spdk-bridge that referenced this pull request Dec 7, 2022
@glimchb
[backend] AIP Get/List/Create/Update/Delete rename
cab5eab 
Resource-oriented design https://google.aip.dev/121

for word in Get List Create Update Delete; do
  for i in AioController NullDebug NVMfRemoteController; do
    sed -i "s/${i}${word}/${word}${i}/g" v1alpha1/backend_*.proto ;
  done;
done

See opiproject/opi-api#217

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkalderon mkalderon mkalderon approved these changes

@sandersms sandersms sandersms approved these changes

@benlwalker benlwalker Awaiting requested review from benlwalker

@GottliebNoam GottliebNoam Awaiting requested review from GottliebNoam

@intelfisz intelfisz Awaiting requested review from intelfisz

@jainvipin jainvipin Awaiting requested review from jainvipin

@llabordehpe llabordehpe Awaiting requested review from llabordehpe

@orendu orendu Awaiting requested review from orendu

Assignees

@glimchb glimchb

Labels
Merge Candidate in the open merge window, next candidate for merge Storage APIs or code related to storage area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glimchb @jainvipin @mkalderon @sandersms