move firmware_version to spec from status

[jainvipin]

addresses #191 pls review @glimchb @benlwalker
I think it wouldn't be a bad idea to keep firmware_version in both spec and status, so for systems that don't want firwmare version to be dynamic, can allow learning about it using status. I can modify the PR to refelect if you all agree. For now I have kept it out ot status.

Signed-off-by: Vipin Jain jainvipin@gmail.com

[glimchb]

@jainvipin can you please clarify the use case again to re-fresh the thread ?

• who would configure this field ? customer ? like cloud orchestrator ?
• how one would see this filed afterwards ? like this ?

$ nvme list
Node             SN              Model                Namespace Usage                      Format           FW Rev
---------------- --------------- -------------------- --------- -------------------------- ---------------- --------
/dev/nvme4n1     MY_SERIAL         MY_MODEL             1         524.29  kB /   1.60  TB    512   B +  0 B   2.1.3

and

$ nvme id-ctrl /dev/nvme1n1 | grep fr
fr        : 2.1.3
frmw      : 0x17

[jainvipin]

closing this PR in favor of offline discussion; the better method to keep the firmware_revision is to tie it to the method delivering the firmware dynamically to the xPU and take it up in lifecycle provisioning work vs. storage APIs.