Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused function #89

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

harishp8889
Copy link
Contributor

Signed-off-by: Harish P harish_p4@dell.com

Signed-off-by: Harish P <harish_p4@dell.com>
@harishp8889 harishp8889 requested a review from a team as a code owner January 12, 2023 12:07
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #89 (4af8320) into main (0503b28) will increase coverage by 9.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   33.98%   43.03%   +9.05%     
==========================================
  Files           1        1              
  Lines         309      244      -65     
==========================================
  Hits          105      105              
+ Misses        188      123      -65     
  Partials       16       16              
Impacted Files Coverage Δ
goopicsi.go 43.03% <ø> (+9.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like new function ExposeRemoteNVMe() can be used instead now, so we can remove this old one

@glimchb glimchb merged commit f17003d into opiproject:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants