Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate HostNQN #62

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Generate HostNQN #62

merged 1 commit into from
Dec 6, 2022

Conversation

harshitap26
Copy link
Contributor

Signed-off-by: Harshita Pandey Harshita_Pandey@dell.com

@harshitap26 harshitap26 requested a review from a team as a code owner December 6, 2022 12:31
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #62 (090333a) into main (3d0de93) will increase coverage by 1.91%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   35.01%   36.92%   +1.91%     
==========================================
  Files           1        1              
  Lines         297      306       +9     
==========================================
+ Hits          104      113       +9     
  Misses        185      185              
  Partials        8        8              
Impacted Files Coverage Δ
goopicsi.go 36.92% <66.66%> (+1.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@harshitap26 harshitap26 force-pushed the generate_uuid branch 2 times, most recently from 92b04ac to 5e76e51 Compare December 6, 2022 13:53
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controllerID needs to be returned as well

goopicsi.go Outdated Show resolved Hide resolved
Signed-off-by: Harshita Pandey <Harshita_Pandey@dell.com>

Resolving checks

Signed-off-by: harshita Pandey <harshita_pandey@dell.com>

Test GenerateHostNQN

Signed-off-by: Harshita Pandey <Harshita_Pandey@dell.com>

Returning ControllerId

Signed-off-by: Harshita Pandey <Harshita_Pandey@dell.com>
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing

@glimchb glimchb merged commit ebc2b7b into opiproject:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants