CreateNVMeSubsystem RPC #58
Conversation
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 33.47% 35.01% +1.54%
==========================================
Files 1 1
Lines 242 297 +55
==========================================
+ Hits 81 104 +23
- Misses 154 185 +31
- Partials 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
harshitap26
force-pushed
the
feature/create-subsystem
branch
from
686774f
to
9eb747f
Compare
Signed-off-by: Harshita Pandey <Harshita_Pandey@dell.com> Added CreateNVMeController RPC Signed-off-by: Harshita Pandey <Harshita_Pandey@dell.com> Added CreateNVMeControllerRPC Signed-off-by: Harshita Pandey <Harshita_Pandey@dell.com>
harshitap26
force-pushed
the
feature/create-subsystem
branch
from
9eb747f
to
290a2fa
Compare
| response1, err := client.CreateNVMeSubsystem(ctx, &pb.CreateNVMeSubsystemRequest{ | ||
| Subsystem: &pb.NVMeSubsystem{ | ||
| Spec: &pb.NVMeSubsystemSpec{ | ||
| Id: &pbc.ObjectKey{Value: subsystemID}, |
There was a problem hiding this comment.
you should generate subsystemID here using, for example uuid.New() user of the library should not care about IDs... he is only aware of NQN...
| if err != nil { | ||
| log.Printf("No existing NVMe Controller found with controllerID %v:", controllerID) | ||
| } | ||
| if data2 == nil { |
There was a problem hiding this comment.
why such a big if here ? just return immediately in case of controller found and then rest of the code is not requiring if
There was a problem hiding this comment.
This if condition is when the controller is not found corresponding to the given controllerID and thus we create a new NVMe controller. In case the controller is found, we are just logging that in line 287
There was a problem hiding this comment.
what I say is just reverse the condition and return first...
if (condition) {
// a lot of code here
}
do
if (!condition) {
log and return
}
// a lot of code here instead
Signed-off-by: Harshita Pandey Harshita_Pandey@dell.com
Added CreateNVMeSubsystem RPC
Added CreateNVMeController RPC