fix(evpn): fix empty vni or vtep in log #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atulpatel261194
force-pushed
the
fix_emptyVniOrVtep
branch
from
852197a
to
b4b2ac5
Compare
artek-koltun
reviewed
May 7, 2024
| log.Println("vni:", lb.GetSpec().GetVni()) | ||
| } | ||
| if lb.GetSpec().GetVtepIpPrefix().GetAddr().GetV4Addr() != 0 { | ||
| Vteip := fmt.Sprintf("%+v/%v", ipconv.IntToIPv4(lb.GetSpec().GetVtepIpPrefix().GetAddr().GetV4Addr()), lb.GetSpec().GetVtepIpPrefix().GetLen()) |
There was a problem hiding this comment.
why we cannot just print zeroes here?
There was a problem hiding this comment.
There are cases where we dont pass the vni or vtep ip i.e vrf without vni & vtep. Then we dont expect them to be printed as zeros.
atulpatel261194
force-pushed
the
fix_emptyVniOrVtep
branch
from
b4b2ac5
to
2e711b8
Compare
Signed-off-by: Atul Patel <Atul.Patel@intel.com>
atulpatel261194
force-pushed
the
fix_emptyVniOrVtep
branch
from
2e711b8
to
d1876ce
Compare
artek-koltun
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.