Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage/backend): opi-api added TcpController and FabricsPath #305

Conversation

artek-koltun
Copy link
Collaborator

Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #305 (513e867) into main (6d8223e) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #305      +/-   ##
========================================
- Coverage   7.98%   7.94%   -0.04%     
========================================
  Files         13      13              
  Lines       2028    2038      +10     
========================================
  Hits         162     162              
- Misses      1848    1858      +10     
  Partials      18      18              
Files Changed Coverage Δ
storage/backend.go 0.00% <0.00%> (ø)
storage/goopicsi.go 40.44% <0.00%> (-0.30%) ⬇️

Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun artek-koltun marked this pull request as ready for review September 19, 2023 12:24
@artek-koltun artek-koltun requested a review from a team as a code owner September 19, 2023 12:24
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@glimchb glimchb merged commit c9aee6e into opiproject:main Sep 19, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants