Add missing box-shadow to text field (primer#2434)

Co-authored-by: Jon Rohan <rohan@github.com>
opf · Dec 13, 2023 · dc87edf · dc87edf
1 parent a7c5e0c
commit dc87edf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/wicked-bats-report.md b/.changeset/wicked-bats-report.md
@@ -0,0 +1,5 @@
+---
+"@primer/view-components": patch
+---
+
+Add missing `box-shadow` to text field
diff --git a/app/components/primer/alpha/text_field.pcss b/app/components/primer/alpha/text_field.pcss
@@ -73,21 +73,23 @@
   color: var(--fgColor-default);
   background-color: var(--bgColor-default);
   border: var(--borderWidth-thin) solid var(--control-borderColor-rest, var(--color-border-default));
+  box-shadow: var(--shadow-inset);
 
   &[disabled] {
     color: var(--control-fgColor-disabled);
     cursor: not-allowed;
     background-color: var(--control-bgColor-disabled);
     border-color: var(--control-borderColor-disabled);
     opacity: 1;
+    box-shadow: none;
     -webkit-text-fill-color: var(--control-fgColor-disabled);
   }
 
-  &:not(:focus)[invalid="true"] {
+  &:not(:focus)[invalid='true'] {
     border-color: var(--control-borderColor-danger);
   }
 
-  &:not(:focus)[invalid="false"] {
+  &:not(:focus)[invalid='false'] {
     border-color: var(--control-borderColor-success);
   }