Always convert CSS classes to system arguments in linters (primer#2445)

.changeset/dirty-shrimps-roll.md

@@ -0,0 +1,5 @@
+---
+'@primer/view-components': minor
+---
+
+Always convert CSS classes to system arguments in linters

lib/primer/classify/utilities.rb

@@ -91,9 +91,6 @@ def mappings(key)
 
         # Extract hash from classes ie. "mr-1 mb-2 foo" => { mr: 1, mb: 2, classes: "foo" }
         def classes_to_hash(classes)
-          # This method is too slow to run in production
-          return { classes: classes } unless validate_class_names?
-
           obj = {}
           classes = classes.split
           # Loop through all classes supplied and reject ones we find a match for

test/lib/classify/utilities_test.rb

@@ -115,10 +115,4 @@ def test_hash_to_args
     assert_equal('mr: [1, 2], classes: "baz bin"', Primer::Classify::Utilities.hash_to_args({ mr: [1, 2], classes: "baz bin" }))
     assert_equal('mr: [1, nil, 2], classes: "foo bar"', Primer::Classify::Utilities.hash_to_args({ mr: [1, nil, 2], classes: "foo bar" }))
   end
-
-  def test_classes_to_hash_returns_classes_when_run_with_validation_disabled
-    with_validate_class_names(false) do
-      assert_equal({ classes: "mr-1 mr-md-2 foo bar" }, Primer::Classify::Utilities.classes_to_hash("mr-1 mr-md-2 foo bar"))
-    end
-  end
 end