[#62486] searching in tokens removes prefix from word

[Kharonus]

Ticket

OP#62486
OP#62255

What are you trying to accomplish?

• searching inside tokens now strips the prefix
• after inserting a token, caret position is placed behind the token

What approach did you choose and why?

• slice prefixes from input words, if word is read from any token
• decide where to put caret dependent on the token to put the caret behind

[NobodysNightmare]

I have one question and will now try the changes practically out in a browser.

[NobodysNightmare]

In Firefox I can't delete tokens anymore. Neither through backspace, nor through delete:

Screencast.from.2025-03-27.11-01-39.webm

Mh, I just double checked to be sure and as far as I can tell, I already have this problem on dev :/

[NobodysNightmare]

I tried understanding the "strip prefix" part and I think I found an off-by-one error. See me inserting a space in random places, just to see from which point the autocompletion starts:

Screencast.from.2025-03-27.11-16-45.webm

In the first word (project) it's fine, but afterwards the first character is cut off.

[Kharonus]

Nice catch, the off by one was introduce by changing one side, but not the other :D -> fixed

As for FF: I can't help with it. For some reason, FF jumps iniine elements with content editable, when hitting backspace. This is what chromium does better. Both have their issues with DEL, which I would indeed label as a bug, but not a critical one.

[github-actions]

Caution

The provided work package version does not match the core version

Details:

• Work package URL: https://community.openproject.org/wp/62486
• Work package version: not set
• Core version: 15.5.0

Please make sure that:

• The work package version OR your pull request target branch is correct

[NobodysNightmare]

Off-by-one error is gone. I now tried understanding the "after inserting a token, caret position is placed behind the token" requirement and played around a bit. In the screencast you see me:

1. Copying a token and subsequently typing
2. Copying the middle of a token and subsequently typing
3. Copying a token plus some pieces left and right and subsequently typing

Of these tests, 1 has non-ideal UX, but feels acceptable, though it might be exactly what you wanted to fix. 2 is just plain weird and I have no clue what's going on. 3 works as expected.

Screencast.from.2025-03-27.13-12-48.webm

[Kharonus]

@NobodysNightmare

I think, I found the reason for backspace not working in firefox and fixed it. Also the partial copy of tokens should work now as expected (at least, as I would expect it :P)

[NobodysNightmare]

Behaviourally LGTM.

Something I realize is that it would probably be great to have nitty-gritty browser-tests for this. E.g. pressing five times backspace or delete.

I understand if you don't want to add them now, but later we'd be happy to have them.